Repository navigation
Passwordless sign-in page: email code, Google and Apple - #5
Merged
Merged
Conversation
Replaces the email/phone/Microsoft draft with three choices, styled after OpenAI's sign-in: Continue with email (then a "Check your inbox" code step, or the link in the email), Google and Apple, through the API's /v1/auth/* routes. - oidc.begin() makes the PKCE verifier and keeps it in localStorage, so the emailed link also works in a new tab; the API only sees the challenge. - The app shell hands the provider's /?code= return to /connect, which was lost on the redirect before. - login_methods from /v1/config decides which buttons work; empty with oidc falls back to Zitadel's hosted pages, and dev mode signs in from the email step without a code. - openapi.json gets the new sign-in routes (merged in, keeping /v1/notifications) and the generated types are refreshed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 394c1f7a96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
With passwordless sign-in on and login_methods lacking "email" (say only Google is set up), the email button now shows as unavailable and explains, instead of opening a step whose request the server would refuse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
Main's Biome cleanup (#6) reformatted the old sign-in page and made its destination a stable callback; this branch replaces that page entirely (and already has the stable callback), so its version is kept and formatted. The app shell's ?code= hand-off and the heading focus rule merged cleanly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… into login-implementation
almas-alright
added a commit
that referenced
this pull request
Oct 27, 2026
Main brought passwordless sign-in (#5). openapi.json keeps this branch's copy, the API's full contract, which already has the sign-in routes; the generated types are regenerated from it. CLAUDE.md keeps both new paragraphs (sign-in, plans). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sign-in page (
/connect) now offers three choices, styled after OpenAI's sign-in: Continue with email (then a "Check your inbox" code step, or the link in the email), Google and Apple, through the API's/v1/auth/*routes.API side: LyricScripts/ScribbleScan#5.
How
oidc.begin()makes the PKCE verifier and keeps it in localStorage, so the emailed link also works in a new tab; the API only sees the challenge./?code=return to/connect; it was lost on the redirect before.login_methodsfrom/v1/configdecides which buttons work. Empty withoidcfalls back to Zitadel's hosted pages; dev mode signs in from the email step without a code.openapi.jsongets the sign-in routes (merged in, keeping/v1/notifications) and the generated types are refreshed.Tested
🤖 Generated with Claude Code