Repository navigation
Fix the Biome errors that fail CI on main - #6
Merged
Merged
Conversation
`biome ci .` has failed on main since #3 with 47 errors. This makes it pass (5 warnings remain, as before). - Biome's safe fixes: formatting and import order across 18 files. - biome.json parses Tailwind's CSS directives (`@theme` was a parse error). - The receipts list's filter now recomputes when receipts change (receipts was missing from its useMemo list: a stale list after loading). - The connect page's destination is a stable callback listed in its effect. - role="group" containers are fieldsets (receipt filters, the heatmap's day grid, the theme picker), with min-w-0 so they still shrink and scroll. - The heatmap's outer box is a labelled section; aria-label is dropped from plain divs, and the less/more scale is hidden from screen readers (each day's button already says its amount). - A few rules are suppressed with the reason next to them: autofocus on the new-space name, the backdrop click and drop zone (Escape, the close button and the file button cover the keyboard), index keys for the server's issue list and for rows whose inputs are controlled, and the app shell's refresh-on-navigation dependency. - A test no longer reads .body from a possibly undefined value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
almas-alright
added a commit
that referenced
this pull request
Oct 27, 2026
Main brought the Biome cleanup (#6), which reformatted the files this branch touches. Took main's versions of app-shell, profile-menu and the upload dialog and re-applied this branch's few lines: the UpgradeDialog mount, PlanSummary in Subscription, and ScansLeft in the upload dialog; formatted the export line in the receipts page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
almas-alright
added a commit
that referenced
this pull request
Oct 27, 2026
Main's Biome cleanup (#6) reformatted the old sign-in page and made its destination a stable callback; this branch replaces that page entirely (and already has the stable callback), so its version is kept and formatted. The app shell's ?code= hand-off and the heading focus rule merged cleanly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
biome ci .has failed onmainsince #3 (47 errors), so every PR's "Lint, types, tests, build" check is red for reasons outside the PR. This makes it pass; the 5 warnings CI already allowed remain.What
biome.json: parse Tailwind's CSS directives (@themeinglobals.csswas a parse error).receiptswas missing from itsuseMemolist).destinationis a stable callback listed in its effect.role="group"containers are now<fieldset>s (receipt filters, heatmap day grid, theme picker), withmin-w-0so they still shrink and scroll. The heatmap's outer box is a labelled<section>;aria-labelis dropped from plaindivs, and the less/more scale is hidden from screen readers (each day's button already says its amount)..bodyfrom a possibly undefined value.Tested
biome cion every tracked file: 0 errors, 5 warnings.next build.Note
Touches many files, so other open branches will need a merge after this lands (#5 conflicts in one file; I'll resolve it there). Seen while testing, not changed here: the selected receipt filter pill has white text on a white background.
🤖 Generated with Claude Code