Repository navigation
Plans: plan and scans in Subscription, one upgrade prompt for every limit - #7
Merged
Merged
Conversation
…ry limit - Subscription (profile menu) shows the plan and this month's automatic scans, with "See plans". - The API's 402 upgrade_required answers become one "ss:upgrade" event (apiError in the client); UpgradeDialog shows the bigger plans with their prices from GET /v1/plan, the suggested one first, and "Email us to upgrade" when the server has a support address. - The upload dialog says how many automatic scans are left, and when none are, that the upload still works and the details are typed in. Hidden while the server reads nothing automatically. - Excel export failures go through apiError, so its limit opens the prompt. - openapi.json is the API's current contract (adds the plan routes; sign-in and reconciliation routes were already on the API). Tested in a browser against the API in dev mode: Subscription, See plans, a business space on Free (402 -> Upgrade to Business), scans left and used up, and Escape closing only the top dialog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65efae3c9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The label came from how many types a plan had, so a plan with two would still promise receipts, invoices and bank statements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main brought the Biome cleanup (#6), which reformatted the files this branch touches. Took main's versions of app-shell, profile-menu and the upload dialog and re-applied this branch's few lines: the UpgradeDialog mount, PlanSummary in Subscription, and ScansLeft in the upload dialog; formatted the export line in the receipts page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… into feature/plans
CI now runs the lint after the build (#4), so Biome was checking the generated .next folder: 15,411 findings, all in build output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
almas-alright
commented
Oct 27, 2026
almas-alright
left a comment
almas-alright
left a comment
Contributor
Author
There was a problem hiding this comment.
conflict occured
Main brought passwordless sign-in (#5). openapi.json keeps this branch's copy, the API's full contract, which already has the sign-in routes; the generated types are regenerated from it. CLAUDE.md keeps both new paragraphs (sign-in, plans). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The web side of plans (API: LyricScripts/ScribbleScan, branch
feature/plans).402 upgrade_requiredanswers become anss:upgradeevent (apiErrorin the client);UpgradeDialogshows the bigger plans with prices fromGET /v1/plan, the suggested one highlighted, and Email us to upgrade when the server has a support address (until payments exist).apiError, so its limit opens the same prompt.openapi.jsonis the API's current contract (adds the plan routes; sign-in and reconciliation routes were already on the API).Tested
test/plan.test.ts),next build, Biome on the new files.Note
Overlaps with #5 (4 files, mostly the generated API files) and #6 (3 files); whichever merges later needs a small merge.
🤖 Generated with Claude Code