Fix sphinx workflow to clone gh-pages from rai-opensource, not petercorke - #205
Open
petercorke wants to merge 2 commits into
Open
Fix sphinx workflow to clone gh-pages from rai-opensource, not petercorke#205petercorke wants to merge 2 commits into
petercorke wants to merge 2 commits into
Conversation
…orke The Commit documentation changes step still cloned the pre-migration petercorke/spatialmath-python repo, which has no gh-pages branch, failing every docs build push with "Remote branch gh-pages not found".
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
The docs at spatialmath-python.rai-inst.com have been stale since January 2025. Merging this one should trigger the first real docs update in a year and a half, and fix the "CI Failing" status |
Hardcoding rai-opensource/spatialmath-python fixes today's problem but
carries the same fragility that broke this originally: an owner/repo
baked into the workflow doesn't track future transfers or renames.
${{ github.repository }} always resolves to whatever repo the workflow
is actually running in.
Collaborator
Author
|
We should also move to publish via GitHub actions not the gh-pages branch. That's a repo setting change + small CI change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit documentation changesstep in.github/workflows/sphinx.ymlstill clonedgh-pagesfrom the pre-migrationpetercorke/spatialmath-pythonrepo, which has nogh-pagesbranch since the repo moved torai-opensource.fatal: Remote branch gh-pages not found in upstream origin(e.g. run 31737932420).rai-opensource/spatialmath-python.git, which has agh-pagesbranch already.Test plan
gh-pagesbranch exists onrai-opensource/spatialmath-pythonsphinxworkflow succeeds onmaster