Skip to content

Test bufsize values of 0 and -1 in decompress() #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptweezy wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Test bufsize values of 0 and -1 in decompress() #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tests/test_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import zlib
from pathlib import Path

from isal import igzip, isal_zlib
from isal import igzip, igzip_lib, isal_zlib

import pytest

Expand Down Expand Up @@ -129,6 +129,16 @@ def test_decompress_isal_zlib(data_size, level):
assert decompressed == data


@pytest.mark.parametrize("module", [isal_zlib, igzip_lib])
def test_decompress_bufsize(module):
data = DATA[:10_000]
compressed = module.compress(data)
# Like zlib.decompress, decompress accepts a bufsize of 0.
assert module.decompress(compressed, bufsize=0) == data
with pytest.raises(ValueError, match="bufsize must be non-negative"):
module.decompress(compressed, bufsize=-1)


@pytest.mark.parametrize(["data_size", "level", "wbits", "memLevel"],
list(itertools.product([128 * 1024], range(4),
WBITS_RANGE, range(1, 10))))
Expand Down
Loading