Repository navigation
Conversation
isal_zlib.decompress() and igzip_lib.decompress() turn a bufsize of 0 into 1 and reject a negative bufsize, as zlib.decompress() does. No test used those values. Without the first check, a bufsize of 0 makes decompress() loop forever.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isal_zlib.decompress()andigzip_lib.decompress()turn abufsizeof 0 into 1 and raiseValueErrorfor a negativebufsize, aszlib.decompress()does. No test used those values. This PR adds a test for both functions.To test it, I removed each of the two checks in
igzip_lib_decompress_impl()inisal_shared.h. All tests intests/test_compat.pyondevelopstill pass. Without the line that turns 0 into 1, the output buffer starts at 0 bytes and doubling it leaves it at 0, sodecompress()never returns, and the new test doesn't finish (I stopped it after 20 s). Without the check for negative values, the new test fails withSystemError.This PR changes only tests, so it has no CHANGELOG entry.
Checklist