Skip to content

Stop passing "rb" as the queue size in the test_close_reader test #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhpvorderman merged 1 commit into from
Oct 27, 2026
Merged

Stop passing "rb" as the queue size in the test_close_reader test #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_igzip_threaded.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def test_threaded_close_error(monkeypatch, threads):

def test_close_reader():
tmp = io.BytesIO(Path(TEST_FILE).read_bytes())
f = igzip_threaded._ThreadedGzipReader(tmp, "rb")
f = igzip_threaded._ThreadedGzipReader(tmp)
f.close()
assert f.closed
# Make sure double closing does not raise errors
Expand Down
Loading