Repository navigation
Conversation
The second parameter of _ThreadedGzipReader is queue_size, so the test
created queue.Queue("rb"). If the reader thread got to put() before
close(), it failed with TypeError.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_close_readercalls_ThreadedGzipReader(tmp, "rb"), but the second parameter isqueue_size, so the reader createsqueue.Queue("rb"). If the reader thread reachesput()beforeclose()stops it, the thread fails withTypeError. pytest then shows aPytestUnhandledThreadExceptionWarning, but the test passes. This has happened in CI, for example in this macOS job and in thisdeveloppush.This PR removes the argument.
This PR changes only tests, so it has no CHANGELOG entry.
Checklist