Repository navigation
Conversation
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
October 13, 2026 13:52
f7111e1 to
73db1b9
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
October 13, 2026 13:58
73db1b9 to
ebf91ce
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
2 times, most recently
from
October 15, 2026 19:18
9ab69a7 to
322b873
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
9 times, most recently
from
October 23, 2026 11:39
e0505ef to
3a034bf
Compare
MESHSTACK_API_USERNAME and MESHSTACK_API_PASSWORD resolve a basic auth credential next to the API key, and meshstack login --username stores it in the profile and checks it with one request. An Authorization now produces a Credential, a BearerToken or a BasicAuth; basic auth cannot refresh, so a 401 is not retried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is callable client.New and NewMeshInfoClient took an internal/http.Client, which no other module can build, and RawClient.DoRequest took its internal request options. internal/http moves to client/http with a smaller surface, internal/version to client/types/version, and ListOptions and Page to client/types, so no exported name of client uses an internal type. TestPublicApiNamesNoInternalType keeps it that way. NewClient takes WithoutRedirects and WithRetry, whose RetryPolicy picks per request which of RetryOnBusy, RetryOnGatewayError and RetryOnBrokenConnection apply; without options it returns the shared client as before. WithHeader replaces WithAccept and WithHeaders, WithBody takes the content type, Send returns the raw response, and an Error names the method and URL. The client.Authorization alias goes; the API docs download moves to internal/apidocs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A building block runner claims runs, registers as a status source, reports status and moves the plan artifact through client.Runner, with the run token for every request about a run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
October 23, 2026 11:53
3a034bf to
eb512e3
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



single-go-bin-runner
building-block-runner moves all its runners into one Go binary. It builds its meshStack client the way the Terraform provider does, through
pkg/auth.ResolveClientwith its config as a setting source, so it gets the CLI's settings, profiles and OIDC login. This PR adds what the runner needs:MESHSTACK_API_USERNAMEandMESHSTACK_API_PASSWORDresolve a basic auth credential next to the API key.meshstack login --usernamestores it in the profile and checks it with one request. AnAuthorizationproduces aCredential, which is aBearerTokenor aBasicAuth. Basic auth cannot refresh, so a 401 is not retried.client/http.internal/httpmoves toclient/http, soclient.Newand the other exportedclientfunctions no longer take types from aninternal/package and are callable from other modules. A test fails when an exported name ofclient/...refers to aninternal/type. New client options:WithoutRedirects()andWithRetry(policy), which decides per method on which failures a request is sent again. Without options a client is the shared client with today's behaviour. The runner uses it for the GitHub, GitLab and Azure DevOps APIs.client.Runner. A runner claims a run, then registers as a status source, reports status and downloads or uploads the artifact with the run's token;ForRunUuidreports with the runner's own credentials. A run's implementation is typed, with one pointer per variant as the building block definition has it, decoded from the flat wire format by itstype. Input values are decoded by their type, and an INTEGER keeps every digit as*big.Int.Cross-repo PRs
github_workflows.repositoryis the bare repository name🤖 Generated with Claude Code