Repository navigation
bb-run-approve-abort: approve and abort building block runs - #27
Merged
Merged
Conversation
grubmeshi
force-pushed
the
feature/bb-run-approve-abort
branch
from
October 5, 2026 14:29
53f3c58 to
6186f13
Compare
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
grubmeshi
force-pushed
the
feature/bb-run-approve-abort
branch
from
October 14, 2026 19:13
6186f13 to
93de0b6
Compare
…bort them The CLI approves and aborts a run through the approve and abort links that meshStack puts on a run while the caller may take the action. The client reads a run and its logs from a link, and sends the token only to a link below the endpoint. The methods sit on a new Client field, so the mocks of the Terraform provider keep compiling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/bb-run-approve-abort
branch
from
October 22, 2026 06:54
93de0b6 to
e0a5d60
Compare
profile delete asked its question and read the answer itself. The commands that approve and abort building block runs ask the same way, so the question moves to the prompt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gblock approve-run The command finds the run that waits for approval through the building block, shows the plan that its predecessor run made, and asks before it approves. The approval names that predecessor, so meshStack refuses it when the run was planned again after the person saw the plan. Because the decision belongs to a person, the command runs only on a terminal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gblock abort-run The command takes the dry run when it is newer than the latest run, and the latest run otherwise. It shows the run and asks before it aborts, so it runs only on a terminal, as approve-run does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/bb-run-approve-abort
branch
from
October 22, 2026 07:09
e0a5d60 to
a20d6f4
Compare
grubmeshi
marked this pull request as ready for review
October 22, 2026 07:09
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



bb-run-approve-abort
Two interactive commands let a person approve or abort a building block run without meshPanel:
meshstack buildingblock approve-run <building-block-uuid>shows the plan of the waiting run and asks "Approve this plan? [y/N]". The approval names the predecessor run that made the shown plan, so meshStack answers 409 when the run was planned again. The CLI then asks you to review the new plan.meshstack buildingblock abort-run <building-block-uuid>takes the newest dry run when there is one, else the latest run, shows it and asks "Abort this run? [y/N]". A 409 means the run can no longer be aborted.Both run only on a terminal, because the decision belongs to a person who saw the run. They follow HAL links only, from the building block to its run and from the run to its actions, and stop before asking when a link is missing. Afterwards they print the building block, because run v1 shows WAITING_FOR_APPROVAL as IN_PROGRESS and ABORTED as FAILED.
The backend, meshcloud/meshfed-release#11281, is released in v2026.43.0.
Reading order
feat(client): the client follows run links; the token goes only to links below the endpoint.refactor:Prompt.Confirm, now used byprofile delete.feat:approve-run.feat:abort-run.For the Terraform provider
Nothing to do on the next bump. The new methods sit on a new
Client.BuildingBlockRunActionfield, so the mocks keep compiling, and the newLinksfield is onMeshBuildingBlockRun, which the provider does not map to a schema.Tests
The acceptance suite here has no terminal, so it cannot drive these commands. The building-block-runner testacc cases
TestAccPlanApproval,TestAccStalePlanandTestAccAbort(meshcloud/building-block-runner#86) cover approve and abort end to end. Unit tests cover what those cannot: the token stays below the endpoint, the terminal check, the approve prompt, the approved plan is the shown one, and 409 on approve.Cross-repo PRs
approveandabortrun endpoints and their links (released)🤖 Generated with Claude Code