Decouple pulse-design assumptions from Amicode core (perception-first) - #534
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (75)
📝 WalkthroughWalkthroughAmicode now presents a domain-agnostic autoresearch workflow. Quantum-control behavior remains active behind domain-pack gates. Pulse-bank statistics, widgets, commands, and terminology are removed or replaced with result-oriented concepts. ChangesAutoresearch identity and guidance
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…s a Domain Pack - Update CONTEXT.md identity sentence and add Domain Pack, Substrate, Run glossary terms - Add ADR documenting the decision: perception-first decoupling of pulse-design assumptions from core - Pulse bank concept marked for removal (catalog serves the same purpose generically)
…trings - Delete pulse-bank.ts widget entirely - Remove pulse-bank from widget registry (widgets.ts) - Remove 'banked' stat from profile API response (profile.ts) - Remove 'banked' from about-you widget config options - Replace pulse-specific CAN items in meet-amico with generic autoresearch - Change meet-amico description from 'Quantum Computing Agent' to 'autoresearch copilot' - Remove 'pulse bank' warm-start prompt from stack_state.ts - Change library widget prompt from 'pulse-design work' to 'research' - Update stack_state test assertion - Re-record golden fixtures Closes #532 (partial)
The pulse-bank widget removal (ADR 0008) deliberately diverges from the fork binary which still serves pulse-bank. The contract test (golden-fixture parity) needs the fork to be updated and goldens re-recorded before re-enabling. Also updates the fixture recorder script to use 'showcase' instead of the removed 'pulse-bank' for the widget-fork test scenarios.
- Rename 'Pulse Inspector' → 'Run Inspector' in entity-rail and session-side-panel - Replace quantum-specific prompt examples with generic autoresearch ones (i18n/en.ts) - Replace 'warm-start from my pulse bank' with 'warm-start from my previous results' (home.tsx) - Replace pulse-specific AMICO_CAN items with generic autoresearch capabilities (home-cards.tsx) - Remove pulse-bank empty-state from entity rail - Rename handoff routing actions: 'pulse-designer' → 'research-session' (research intent now routes through a generic domain fork; today it has one option) - Update handoff routing tests to match new action names
…532) - Add isQuantumControlPackActive() gate in extension.ts (always true today) - Wrap Julia auto-offer setup behind the gate - Fix vault prompt: 'pulses' → 'results' - Add QUANTUM_CONTROL_PACK_ACTIVE gate in amicode_tools.ts - Wrap domain-specific tools (pick_system, set_model, formulate, solve, to_hardware, calibrate) in conditional spread — always included today, but visibly gated and documented as domain-pack-specific (ADR 0008) - Generic tools (problem, profile, verify, veloce) remain unconditional
AGENTS.md drops from 483 lines to 160 — all quantum-control-specific workflow content removed: - ## Workflow (tier resolution, gate launch, amico-run lifecycle) - ## Pulse-designer interview (already in scores/pulse-designer/SCORE.md) - ## The run-dir contract (AMICODE_ITER, AMICODE_PULSE, result.toml) - ## Warm-start idiom - ## Julia project What remains: - ## Identity (Amico, autoresearch copilot) - ## Voice - ## The error-corrected research loop (generic) - ## Workflow (generic pointer to skills) - ## Answering 'What can Amicode do?' (loop-first, domain-capabilities second) - ## Style & formatting (generic) - <!-- AMICODE_SCORE_SECTION --> splice marker for compiled scores The 'What can Amicode do?' section is rewritten to lead with the autoresearch loop, then mention active domain capabilities (currently: quantum control). Tests updated: - agents_md.test.ts: workflow/routing/interview blocks skipped (content in skill) - scores/compiler.test.ts: check Style section instead of removed run-dir contract - scores/loop_first.test.ts: check splice marker; assert run-dir NOT in template - scores/prep_integration.test.ts: fallback is the generic loop, not the interview
…al) (#532) Move 19 quantum-control-specific skills from the public extension bundle (packages/extension/skills/) to the team vault (armonissima/skills/) with surface: internal frontmatter. This completes the domain-pack boundary: Moved skills: atoms, bosonic, compose, constraints, demo, design-a-pulse, fluxonium, ions, multistart, objectives, pasqal, plot, problem-types, setup, simulate, solve, structural-analysis, transmon, warm-start These skills are now visible only to team users (with armonissima mounted). Public Marketplace users see only the generic autoresearch skills. - Rename DEFAULT_PLATFORM_SKILLS → QUANTUM_CONTROL_SKILLS (documentation anchor) - Update package_skills discovery test to verify public root exclusion - Full resolution (public + vault) still finds all skills on team machines
- Vault setup prompt: 'pulses' → 'results' (was lost during branch switching) - Convergence notification: remove 'Save pulse' instruction, say 'result artifact saved' - Save-pulse command confirmation: 'pulse saved' → 'result artifact saved'
The save/promote flow is now the agent's job (via the design-a-pulse skill), not a VS Code command or notification popup. - Remove amicode.savePulse command registration entirely - Remove convergence popup (runs_manager.ts) — log to output channel only - Remove savePulseTo import (unused) - Remove savePulse from chat_bridge command allowlist - Update runs_manager test (popup no longer fires)
…r label Sync overlay with fork: panel-menu.tsx gains group support, session-side-panel.tsx reverts to 'Pulse Inspector' under a 'Quantum' section.
jeonghun-jj-lee
force-pushed
the
532-decouple-pulse-design-from-core
branch
from
August 24, 2026 13:03
bd59cde to
6680fb2
Compare
jeonghun-jj-lee
marked this pull request as ready for review
August 24, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #532
Summary
Perception-first decoupling of quantum-control assumptions from Amicode's core (ADR 0008). Quantum control remains tightly integrated as the primary domain pack — but the interface now speaks autoresearch generically, and domain-specific code is visibly gated.
Changes
Pulse bank removal (the real functional change):
bankedstat from the profile APIUI vocabulary generalized:
Handoff routing generalized:
pulse-designer→research-sessionaction namesDomain-specific infrastructure gated (ADR 0008):
isQuantumControlPackActive()gate in extension.ts (always true today)AGENTS.md restructured (483 → 160 lines):
Architecture decision recorded:
docs/adr/0008-autoresearch-identity-domain-pack-boundary.mdTest status
Follow-up needed (separate PR)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation