Skip to content

fix(ci): green the 534 follow-up — profile parity, widget hash, bundle drift, packaging gate - #547

Merged
Rchari1 merged 1 commit into
mainfrom
fix/ci-green-534-followup
Aug 24, 2026
Merged

fix(ci): green the 534 follow-up — profile parity, widget hash, bundle drift, packaging gate#547
Rchari1 merged 1 commit into
mainfrom
fix/ci-green-534-followup

Conversation

@Rchari1

@Rchari1 Rchari1 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Fixes the red on main after #534 (refactor: decouple pulse-design from core).

Root causes (3 gates, 5 files):

  • fast — amicode_service_contract 4 failures: profileBody omitted the fork-parity fields role, description, github, custom_link (golden already expects them as null). Restored the 4 fields.
  • fast — amicode_service_contract 1 failure: library widget hash drift (prompt changed pulse-design workresearch in same PR, golden still carried old 7c01). Synced golden to f86f (the built hash the service now emits).
  • app-bundle-gate: 6 overlay files were edited for the grouped panel-menu refactor but manifest.json still pinned the pre-edit hashes — drift gate failed on panel-menu.tsx. Synced the 6 stale hashes to the on-disk overlay.
  • vsix-gate: REQUIRED pinned the now-internal skills/atoms (quantum-control pack moved internal per ADR 0008). Pointed it at the still-public amico-vault.

Verification

  • pnpm --filter amicode exec vitest run --exclude '**/slow/**' — 107 files, 1511 passed
  • pnpm --filter amicode exec vitest run test/amicode_service_contract.test.ts — 74 passed
  • AMICODE_REQUIRE_VSIX=1 pnpm --filter amicode exec vitest run test/packaging.test.ts — 5 passed
  • node packages/app-bundle/scripts/drift_gate.mjs — PASS (committed overlay, no fork clone)

No functional change beyond restoring the parity the tests pin.

Summary by CodeRabbit

  • New Features

    • Profile information now includes role, description, GitHub details, and valid custom links.
    • Invalid custom link data is handled safely without disrupting profile responses.
  • Bug Fixes

    • Updated packaged resources and validation checks to ensure the latest content is included and recognized correctly.

…e drift, packaging gate

- profile: restore fork-parity fields (role, description, github,
  custom_link) omitted in 4122be7; golden already expects them —
  fixes 4/5 fast failures (cold/warm reads).
- widgets: sync golden library hash to the research-prompt variant
  (7c01→f86f) introduced in same PR; the committed golden still
  carried the pulse-design hash.
- app-bundle: sync manifest hashes for the 6 overlay files touched
  by the grouped panel-menu refactor (panel-menu, en.ts, home.tsx,
  session-side-panel, entity-rail, home-cards) — drift gate now
  passes committed-overlay check.
- packaging: point REQUIRED skill from removed atoms to the still-public
  amico-vault (20 public skills remain after quantum-control pack
  moved internal per ADR 0008).

Closes CI red on main (app-bundle-gate + fast + vsix-gate).
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ef071b34-5011-4f4f-b201-5933be88bde8

📥 Commits

Reviewing files that changed from the base of the PR and between 1e205d9 and 3a82c8f.

📒 Files selected for processing (4)
  • packages/app-bundle/manifest.json
  • packages/extension/src/amicode_service/profile.ts
  • packages/extension/test/fixtures/amicode/golden.json
  • packages/extension/test/packaging.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The extension profile response now includes additional profile fields with validation for custom_link. Packaging tests and golden fixture metadata were updated. The app bundle manifest records new content hashes for six tracked files.

Changes

Extension profile and packaging

Layer / File(s) Summary
Profile response fields
packages/extension/src/amicode_service/profile.ts
The profile response now returns role, description, and github strings. It returns object-valued custom_link data and null for invalid values.
Packaging expectations
packages/extension/test/fixtures/amicode/golden.json, packages/extension/test/packaging.test.ts
The golden fixture uses the updated library widget hash. The packaging test requires the amico-vault skill.
Bundle content hashes
packages/app-bundle/manifest.json
The manifest records updated hashes for six tracked application and UI files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 3a82c

This PR restores expected profile parity, synchronized hashes, and packaging references while reporting passing validation checks; no actionable merge-blocking risk remains beyond normal review.

Suggested reviewers: aarontrowbridge, jeonghun-jj-lee

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the CI follow-up and the four related fixes: profile parity, widget hash, bundle drift, and packaging validation.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-green-534-followup

Comment @coderabbitai help to get the list of available commands.

@Rchari1
Rchari1 merged commit 791d467 into main Aug 24, 2026
7 of 8 checks passed
@Rchari1
Rchari1 deleted the fix/ci-green-534-followup branch August 24, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant