fix(ci): green the 534 follow-up — profile parity, widget hash, bundle drift, packaging gate - #547
Conversation
…e drift, packaging gate - profile: restore fork-parity fields (role, description, github, custom_link) omitted in 4122be7; golden already expects them — fixes 4/5 fast failures (cold/warm reads). - widgets: sync golden library hash to the research-prompt variant (7c01→f86f) introduced in same PR; the committed golden still carried the pulse-design hash. - app-bundle: sync manifest hashes for the 6 overlay files touched by the grouped panel-menu refactor (panel-menu, en.ts, home.tsx, session-side-panel, entity-rail, home-cards) — drift gate now passes committed-overlay check. - packaging: point REQUIRED skill from removed atoms to the still-public amico-vault (20 public skills remain after quantum-control pack moved internal per ADR 0008). Closes CI red on main (app-bundle-gate + fast + vsix-gate).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe extension profile response now includes additional profile fields with validation for ChangesExtension profile and packaging
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR restores expected profile parity, synchronized hashes, and packaging references while reporting passing validation checks; no actionable merge-blocking risk remains beyond normal review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Fixes the red on
mainafter #534 (refactor: decouple pulse-design from core).Root causes (3 gates, 5 files):
amicode_service_contract4 failures:profileBodyomitted the fork-parity fieldsrole,description,github,custom_link(golden already expects them asnull). Restored the 4 fields.amicode_service_contract1 failure: library widget hash drift (prompt changedpulse-design work→researchin same PR, golden still carried old7c01). Synced golden tof86f(the built hash the service now emits).manifest.jsonstill pinned the pre-edit hashes — drift gate failed onpanel-menu.tsx. Synced the 6 stale hashes to the on-disk overlay.REQUIREDpinned the now-internalskills/atoms(quantum-control pack moved internal per ADR 0008). Pointed it at the still-publicamico-vault.Verification
pnpm --filter amicode exec vitest run --exclude '**/slow/**'— 107 files, 1511 passedpnpm --filter amicode exec vitest run test/amicode_service_contract.test.ts— 74 passedAMICODE_REQUIRE_VSIX=1 pnpm --filter amicode exec vitest run test/packaging.test.ts— 5 passednode packages/app-bundle/scripts/drift_gate.mjs— PASS (committed overlay, no fork clone)No functional change beyond restoring the parity the tests pin.
Summary by CodeRabbit
New Features
Bug Fixes