Repository navigation
Conversation
…ames) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
gitluis
pushed a commit
that referenced
this pull request
Nov 4, 2026
…low the merge order Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
gitluis
pushed a commit
that referenced
this pull request
Nov 4, 2026
…low the merge order Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
This was referenced Nov 4, 2026
Conflicts were the version lines and the top of the CHANGELOG: kept the stack's content with v2.0.2 and this PR's entry on top. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
Storage no longer carries the app's name, so a rename never touches data. Names only, as decided: nothing is copied from the old finlens_* names, so the app opens empty after updating (export JSON first, then re-import). The old file names stay git-ignored; published AI Eval results still load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two parts, both so the app's name never ties down anyone's data:
1. Storage names
finlens_dbapp_dbfinlens_fsapp_fsfinlens_*app_*finlens-state.jsonapp-state.jsonfinlens-state-backup-*.jsonapp-state-backup-*.jsonfinlens-export-*.jsonapp-export-*.jsonfinlens-analysis-*.md,finlens-ai-history-*.mdai-analysis-*.md,ai-history-*.mdkindfinlens-ai-evalai-eval-results(old files still load, incl. the published runs)Names only, as you decided: nothing is copied from the old names. FinLens never sees your data either way. The old copies stay where they are in your browser and folder, but the new version doesn't read them, so it opens empty after updating. See "Before you merge" below.
.gitignorelists only the new file names (your call).data/is still ignored as a whole, but an oldfinlens-state.jsonor export sitting anywhere else in the repo folder no longer is, so don't leave those there.2. Rename script
python3 .github/scripts/rename_app.py "NewName"lists every place the name "FinLens" / "FINLENS" appears (dry run), and--applychanges them: page title, app bar, footer, Settings, messages, README, current docs, and favicon letters if any. History stays as written (older CHANGELOG entries, published eval results,docs/archive/). The AI request doesn't contain the name, so a rename needs no eval re-run.Version: v2.0.2.
Before you merge this (your data)
finlens-export-YYYYMMDD.json).app-state.jsonin your folder. Delete the oldfinlens-state.json(and anyfinlens-state-backup-*.json) when you're happy.How it was tested (headless Chromium 153, on this branch)
app_dbandapp_fsdatabases andapp_*keys. An oldfinlens_themekey set before loading is ignored (theme stays light), as decided.app-export-20261104.json.docs/eval-results.json(kindfinlens-ai-eval) still loads.app_*key and both databases (the app recreates them empty when it reloads).finlensare left, all on purpose: repo URLs and the old eval kind it still accepts.app-state.jsonbeing written and read in your folder is only checked by code review. Please test it (steps 3–4 above).When the name is picked
master). If v1.18.2: a transfer keyword alone no longer hides money sent or received; flag those for review #59 or anything else merged first, search the diff forfinlens-state.json/finlens_: newer text may use the old storage names. Rename them as in the table.python3 .github/scripts/rename_app.py "NewName", read the list, then run it with--apply. Add a line about the name to this PR's CHANGELOG entry, commit and push.git remote set-url origin https://github.com/gitluis/<new-name>.git.Manual testing (step by step)
Do steps 1–5 in a separate browser profile (or after exporting, per "Before you merge"), so your real data isn't touched.
rename-appand openindex.htmlin Edge or Chrome. The footer and Settings → General say v2.0.2.finlens_*storage is ignored).app_dbandapp_fs; Local storage keys start withapp_, none withfinlens_.app-export-YYYYMMDD.json.app-state.json, notfinlens-state.json. Reload, reconnect if asked: the budget from step 3 is still there.app_*keys left, and the app reopens on the Welcome. Oldfinlens_*storage (if any) is untouched.python3 .github/scripts/rename_app.py "TestName"lists the changes without editing anything;git statusstays clean.Please check before merging
app-state.jsonhttps://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
Generated by Claude Code