Repository navigation
Conversation
…ions) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
…be read Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
4 tasks
…low the merge order Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
Draft
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Product rules check that runs on every pull request and every push to
master. It enforces the house rules that are easy to miss by hand. The app itself doesn't change..github/bank-names.txt(28 names, incl. Puerto Rico banks)docs/eval-runs/,docs/archive/,docs/EVAL.md,docs/eval-results.json, andjs/migrate.js(the migration has to recognize the old ids)index.htmlfooter, both README lines, Settings → General and CLAUDE.md §1 (§17)The last one catches the "version already taken" problem before merging, instead of renumbering after a conflict.
Names that are also everyday words ("Popular", "Discover", "Citizens") are listed only in forms that can't be everyday words ("Banco Popular", "Popular Bank"), so normal text doesn't trip the check. Edit the list freely; it's plain text.
Version: v2.0.4 (renumbered from v2.0.3 when the rename PR #58 took v2.0.2 and #56 moved to v2.0.3; the renumber commit message names the wrong PR version, this line is the correct one).
How it was tested (locally)
mastercontent: 221 bank names in 33 files (Ally, Chase, and one "Fidelity" in an account-name placeholder). The PR's own check is red because of this.js/migrate.jslegitimately keeps the old ids, and the redesign shows "FinLens v1.18.1" without the·thatmasterhas.masterand not used by any of the other 39 open PRs.Manual testing (step by step)
CLAUDE.md,js/core.js,samples/…file names). The last lines should sayVersion: v2.0.4,Newer than master (v1.10.5)andNot used by any of the other … open PRs, with no version errors.CHANGELOG.md. The bank names in older entries are not flagged, only new text would be.Please check before merging
.github/bank-names.txtmasterhttps://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
Generated by Claude Code