Skip to content

v2.0.1: browser smoke tests in CI (Chromium + Edge) - #55

Draft
gitluis wants to merge 2 commits into
masterfrom
ci-browser-tests
Draft

gitluis wants to merge 2 commits into
masterfrom
ci-browser-tests

Conversation

@gitluis

@gitluis gitluis commented Nov 4, 2026

Copy link
Copy Markdown
Owner

On hold — draft on purpose. Part of the v2.0 — Public launch milestone. Leave this open until the app is more mature, renamed and on a custom domain. Mark it "Ready for review" when you want to merge it.

Summary

Turns the ad hoc headless checks from past sessions into a committed test that runs on every PR, in Chromium and Edge. The app itself doesn't change.

tests/browser/smoke.cjs serves the repo over HTTP, opens it with Playwright and checks:

Area Checks
Boot No page errors, console errors or dialogs. The footer version matches the top CHANGELOG entry
Every view All 24 registered views render with no errors, once empty and once with sample data
Sample import Every row of every samples/*.csv imports, one account per file, amounts are whole cents, dates are valid, ids are unique, transfers are detected, income − spending = net of non-transfer rows to the cent, and re-importing adds no rows
Money formatting fmt() rounds float drift (0.1 + 0.2 → $0.30) and never shows -$0.00

Known bugs become tests

KNOWN_BUGS lists checks that should pass once a bug is fixed. While they fail, CI stays green and prints xfail. When a fix makes one pass, CI goes red and says to remove it from the list. A fixed bug can't quietly come back.

First entry: fmt() shows -$0.00 for -0.001 and -0.004 (it's on the findings list from 2026-11-02).

Versions: v2.0.1. Playwright 1.63.0 is installed in CI only (npm install --no-save). There's no package.json, and the app stays npm-free. node_modules/ is now git-ignored.

How it was tested

  • Ran locally in headless Chromium 153: 14 passed, 0 failed, 1 known bug still failing.
  • The CDNs are blocked from my workspace, so locally the five CDN scripts were served from the same versions on npm (CDN_MIRROR) and Google Fonts were skipped. On GitHub the real CDNs and fonts load. That, and Edge, are only verified by the Actions run on this PR.
  • Sample import numbers: 257 rows → 257 transactions in 3 accounts, 30 transfers, income $32,524.88, spending $16,795.07.

Finance note (not asserted)

The 30 transfers net to −$230.00, not $0. Paired legs cancel out, so the gap comes from keyword-matched transfers with no matching leg in another account (money that left for an account FinLens doesn't have). I didn't make "transfers net to zero" a test, because with only some accounts loaded that's expected. Worth a look when we work on the Transfers view: it could show paired and one-sided transfers separately.

Not covered

Manual testing (step by step)

  1. Open the Checks tab. You should see Smoke tests (chromium) and Smoke tests (msedge), both green.
  2. Open one and expand Run smoke tests. It should end with 14 passed, 0 failed, 1 known bugs still failing, 0 known bugs now fixed, plus a line xfail fmt never shows -$0.00 (known bug).
  3. (Optional, locally) Install Playwright (npm install --no-save playwright@1.63.0 && npx playwright install chromium), then run node tests/browser/smoke.cjs from the repo root. You should get the same summary.
  4. Open index.html and check the footer and Settings → General say v2.0.1.

Please check before merging

  • Both browser jobs green
  • Version v2.0.1 isn't taken by anything merged before this (renumber if so)
  • If the "-$0.00" fix has merged first, remove it from KNOWN_BUGS (CI will go red and tell you to)

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI, GitHub Actions and repo tooling on-hold Ready, but intentionally left open until a later decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants