Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
This was referenced Nov 4, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the ad hoc headless checks from past sessions into a committed test that runs on every PR, in Chromium and Edge. The app itself doesn't change.
tests/browser/smoke.cjsserves the repo over HTTP, opens it with Playwright and checks:samples/*.csvimports, one account per file, amounts are whole cents, dates are valid, ids are unique, transfers are detected, income − spending = net of non-transfer rows to the cent, and re-importing adds no rowsfmt()rounds float drift (0.1 + 0.2→$0.30) and never shows-$0.00Known bugs become tests
KNOWN_BUGSlists checks that should pass once a bug is fixed. While they fail, CI stays green and printsxfail. When a fix makes one pass, CI goes red and says to remove it from the list. A fixed bug can't quietly come back.First entry:
fmt()shows-$0.00for-0.001and-0.004(it's on the findings list from 2026-11-02).Versions: v2.0.1. Playwright 1.63.0 is installed in CI only (
npm install --no-save). There's nopackage.json, and the app stays npm-free.node_modules/is now git-ignored.How it was tested
CDN_MIRROR) and Google Fonts were skipped. On GitHub the real CDNs and fonts load. That, and Edge, are only verified by the Actions run on this PR.Finance note (not asserted)
The 30 transfers net to −$230.00, not $0. Paired legs cancel out, so the gap comes from keyword-matched transfers with no matching leg in another account (money that left for an account FinLens doesn't have). I didn't make "transfers net to zero" a test, because with only some accounts loaded that's expected. Worth a look when we work on the Transfers view: it could show paired and one-sided transfers separately.
Not covered
finlens-state.json(headless has no real folder). Keep these in your manual testing.master. Once the stack merges, the sample filenames and account kinds change. The test reads whatever is insamples/, so it should keep working, but the first run after the stack merges is the real check.Manual testing (step by step)
14 passed, 0 failed, 1 known bugs still failing, 0 known bugs now fixed, plus a linexfail fmt never shows -$0.00 (known bug).npm install --no-save playwright@1.63.0 && npx playwright install chromium), then runnode tests/browser/smoke.cjsfrom the repo root. You should get the same summary.index.htmland check the footer and Settings → General say v2.0.1.Please check before merging
KNOWN_BUGS(CI will go red and tell you to)Generated by Claude Code