Skip to content

feat(investigations): Apply update_detector requests as the user - #128723

Open
wedamija wants to merge 4 commits into
danf/inv-fu-16-applyfrom
danf/inv-fu-17-update-detector-apply
Open

wedamija wants to merge 4 commits into
danf/inv-fu-16-applyfrom
danf/inv-fu-17-update-detector-apply

Conversation

@wedamija

@wedamija wedamija commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This applies a suggested monitor change as the user who clicked, through the detector validator, or only checks it on a dry run. If any setting Seer relied on changed since the suggestion, nothing is applied and the user sees which settings moved. A change the validator rejects stays suggested, so it can be tried again.

Depends on #128681

@wedamija
wedamija requested review from a team as code owners October 23, 2026 23:17
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2026
@wedamija
wedamija force-pushed the danf/inv-fu-16-apply branch from 8189800 to 132da5c Compare October 23, 2026 23:28
@wedamija
wedamija requested review from a team as code owners October 23, 2026 23:28
@wedamija
wedamija force-pushed the danf/inv-fu-17-update-detector-apply branch from 96b9f20 to 82a3121 Compare October 23, 2026 23:28
wedamija added a commit that referenced this pull request Oct 23, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an Apply button to a suggested monitor change. When the card shows, it asks the backend with a dry run whether the change would apply, and says why when it can't, so the user only clicks a change that will save.

Depends on #128681 and #128723
@wedamija
wedamija requested a review from billyvg October 23, 2026 23:41
@wedamija
wedamija force-pushed the danf/inv-fu-16-apply branch from 132da5c to 36395e9 Compare October 24, 2026 01:10
@wedamija
wedamija force-pushed the danf/inv-fu-17-update-detector-apply branch from 82a3121 to b40ebfd Compare October 24, 2026 01:10
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an Apply button to a suggested monitor change. When the card shows, it asks the backend with a dry run whether the change would apply, and says why when it can't, so the user only clicks a change that will save.

Depends on #128681 and #128723
@wedamija
wedamija force-pushed the danf/inv-fu-17-update-detector-apply branch from b40ebfd to 0c3a92b Compare October 24, 2026 01:30
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an Apply button to a suggested monitor change. When the card shows, it asks the backend with a dry run whether the change would apply, and says why when it can't, so the user only clicks a change that will save.

Depends on #128681 and #128723
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This applies a suggested monitor change as the user who clicked, through the detector validator, or only checks it on a dry run. If someone changed the monitor after Seer made the suggestion, nothing is applied, and the user sees which settings moved.

Depends on #128681
… path

The kind only makes the change now. It raises when the monitor is stale or the change is invalid, locks the monitor until it saves, and checks every setting Seer relied on, not just the ones it changes. A rejected change stays suggested so the user can try again, and applying no longer bumps the notebook version.
@wedamija
wedamija force-pushed the danf/inv-fu-16-apply branch from 5e558ca to 52db83c Compare October 24, 2026 03:49
@wedamija
wedamija force-pushed the danf/inv-fu-17-update-detector-apply branch from 0c3a92b to 54109e5 Compare October 24, 2026 03:49
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an Apply button to a suggested monitor change. When the card shows, it asks the backend with a dry run whether the change would apply, and says why when it can't, so the user only clicks a change that will save.

Depends on #128681 and #128723
Look up the monitor in the investigation's organization and return 404
when it's gone or has no query, instead of a 500.
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an Apply button to a suggested monitor change. When the card shows, it asks the backend with a dry run whether the change would apply, and says why when it can't, so the user only clicks a change that will save.

Depends on #128681 and #128723

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant