Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment:
Preview deployment: https://sentry-cnemilq73.sentry.dev |
wedamija
changed the base branch from
master
to
danf/inv-fu-17-update-detector-apply
October 23, 2026 23:28
wedamija
marked this pull request as ready for review
October 23, 2026 23:28
wedamija
force-pushed
the
danf/inv-fu-17-update-detector-apply
branch
from
October 23, 2026 23:28
96b9f20 to
82a3121
Compare
wedamija
force-pushed
the
danf/inv-fu-25-apply
branch
from
October 23, 2026 23:28
5ae36d2 to
50d1502
Compare
wedamija
force-pushed
the
danf/inv-fu-17-update-detector-apply
branch
from
October 24, 2026 01:10
82a3121 to
b40ebfd
Compare
wedamija
force-pushed
the
danf/inv-fu-25-apply
branch
from
October 24, 2026 01:13
50d1502 to
675c6e9
Compare
wedamija
added a commit
that referenced
this pull request
Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click. This keeps an action request on the card after it's applied or fails, showing who applied it and what changed on the monitor, or why the change didn't save. Depends on #128724
wedamija
force-pushed
the
danf/inv-fu-17-update-detector-apply
branch
from
October 24, 2026 01:30
b40ebfd to
0c3a92b
Compare
wedamija
force-pushed
the
danf/inv-fu-25-apply
branch
from
October 24, 2026 01:30
675c6e9 to
884eb5c
Compare
wedamija
added a commit
that referenced
this pull request
Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click. This keeps an action request on the card after it's applied or fails, showing who applied it and what changed on the monitor, or why the change didn't save. Depends on #128724
wedamija
force-pushed
the
danf/inv-fu-17-update-detector-apply
branch
from
October 24, 2026 03:49
0c3a92b to
54109e5
Compare
wedamija
force-pushed
the
danf/inv-fu-25-apply
branch
from
October 24, 2026 03:51
884eb5c to
94355e6
Compare
wedamija
added a commit
that referenced
this pull request
Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click. This keeps an action request on the card after it's applied, showing who applied it and what changed on the monitor. When the backend rejects a change, the card says why and leaves Apply available. Depends on #128724
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
wedamija
added a commit
that referenced
this pull request
Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click. This keeps an action request on the card after it's applied, showing who applied it and what changed on the monitor. When the backend rejects a change, the card says why and leaves Apply available. Depends on #128724
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click. This adds an Apply button to a suggested monitor change. When the card shows, it asks the backend with a dry run whether the change would apply, and says why when it can't, so the user only clicks a change that will save. Depends on #128681 and #128723
The button stays disabled while the dry run runs and keeps its last answer through a refetch. Only a rejection with a code blocks it, the reason uses the code's copy, and it's linked for screen readers. The check reruns when Seer changes the action.
…action The dry run kept its last answer as placeholder data, so the button stayed enabled for a change that hadn't been checked. A refetch of the same check keeps its data anyway, so the placeholder isn't needed.
Move update_detector's apply button, details and copy into a per-kind object, and say per kind whether the UI checks a change before applying it. Refetch only what an apply changed, type the request error with the apply error schema, and drop the shared stale copy no kind reaches.
A disabled query still reports pending, so a kind without a pre-apply check kept a busy, disabled button.
Only stale, already_applied and withdrawn refreshed it, so a superseded or no longer permitted request kept an enabled button until a reload.
…er hidden one A superseded primary with a higher id hid the live suggestion.
wedamija
force-pushed
the
danf/inv-fu-25-apply
branch
from
October 24, 2026 06:13
18468b3 to
d954e3a
Compare
wedamija
added a commit
that referenced
this pull request
Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click. This keeps an action request on the card after it's applied, showing who applied it and what changed on the monitor. When the backend rejects a change, the card says why and leaves Apply available. Depends on #128724
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d954e3a. Configure here.
…xt step Skipping applied primaries made a completed next step look missing, so the page refetched and showed the loading placeholder.
wedamija
added a commit
that referenced
this pull request
Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click. This keeps an action request on the card after it's applied, showing who applied it and what changed on the monitor. When the backend rejects a change, the card says why and leaves Apply available. Depends on #128724
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.
This adds an Apply button to a suggested monitor change. When the card shows, it asks the backend with a dry run whether the change would apply, and says why when it can't, so the user only clicks a change that will save.
Depends on #128681 and #128723