Repository navigation
D2-2690: Update plugin for latest MCP deploy - #51
Conversation
nicobatalla
left a comment
nicobatalla
left a comment
There was a problem hiding this comment.
Ran a review locally, codex had some findings. I think the gateway scope one looks legit
|
|
||
| **Adding a secret.** No tool accepts a secret's value, so the user always types it into the Hub: | ||
|
|
||
| 1. Check `dtwo-list-vault-entries` with the `name` first. If an entry exists, reuse it. |
There was a problem hiding this comment.
Searching by name returns entries across gateway scopes. If gateway A owns GITHUB_TOKEN, this instruction tells the agent to reuse it for gateway B, where it cannot resolve. Please check the returned scope before reusing an entry: it must be account-wide or belong to the target gateway. If the only matches belong to other gateways, create an entry for the target gateway.
|
|
||
| **Plain entries.** For a non-secret value used by several configs (an upstream URL, a timeout), `dtwo-create-vault-entry` stores it as given. A reference resolves to a string, so it can't fill a numeric or boolean field yet. | ||
|
|
||
| **Changing a value.** Running gateways keep the old value until they are next deployed, so offer a redeploy after a value changes. |
There was a problem hiding this comment.
Please distinguish gateway config values from sidecar values here. Deploy applies rotated values to gateway configuration, but it does not rewrite the sidecar .env. A sidecar keeps using the old credential until Update or Restart. Since this section also covers sidecar references, the agent should direct the user to Update or Restart when the changed entry is used by a sidecar.
Issue https://github.com/dtwoai/d2/issues/2690
Update the claude plugin to use the new vault and policy catalog tools from the MCP server.