-
Notifications
You must be signed in to change notification settings - Fork 797
feat(teleop): add PICO WebXR body tracking #3695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
80a7d98
feat(teleop): add PICO WebXR body tracking
TomCC7 3d49b9a
Delete docs/research/pico-webxr-body-tracking.md
TomCC7 6580b8b
fix(teleop): accept PICO controller button layout
TomCC7 7fc9bd1
fix(webxr): simplify PICO input handling
TomCC7 6bcf67d
test(webxr): cover mixed message dispatch
TomCC7 82d7bc6
fix(webxr): reject short controller packets
TomCC7 91fda14
test(webxr): isolate body monitor timing
TomCC7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # Copyright 2026 Dimensional Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Body-joint snapshots received from a WebXR client.""" | ||
|
|
||
| from typing import Annotated, Literal, TypeAlias | ||
|
|
||
| from pydantic import BaseModel, ConfigDict, Field, StringConstraints | ||
|
|
||
| BodyTrackingMode: TypeAlias = Literal["off", "optional", "required"] | ||
| _FiniteFloat: TypeAlias = Annotated[float, Field(strict=True, allow_inf_nan=False)] | ||
| _NonEmptyString: TypeAlias = Annotated[ | ||
| str, | ||
| StringConstraints(min_length=1, pattern=r".*\S.*"), | ||
| ] | ||
|
|
||
|
|
||
| class BodyJointPose(BaseModel): | ||
| """One body joint's pose in the snapshot's WebXR reference space.""" | ||
|
|
||
| model_config = ConfigDict(extra="forbid", frozen=True) | ||
|
|
||
| position: tuple[_FiniteFloat, _FiniteFloat, _FiniteFloat] | ||
| orientation: tuple[_FiniteFloat, _FiniteFloat, _FiniteFloat, _FiniteFloat] | ||
|
|
||
|
|
||
| class BodyTrackingSnapshot(BaseModel): | ||
| """Named body-joint poses captured in one WebXR reference space. | ||
|
|
||
| ``joints=None`` means the body source is unavailable. An empty mapping | ||
| means the source is available but did not resolve any joints. | ||
| """ | ||
|
|
||
| model_config = ConfigDict(extra="forbid", frozen=True) | ||
|
|
||
| type: Literal["body_tracking_snapshot"] | ||
| capture_time_s: _FiniteFloat | ||
| frame_id: _NonEmptyString | ||
| joints: dict[_NonEmptyString, BodyJointPose] | None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| # Copyright 2026 Dimensional Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Live health reporting for the PICO WebXR body-tracking demo.""" | ||
|
|
||
| from time import monotonic | ||
| from typing import Any | ||
|
|
||
| from reactivex.disposable import Disposable | ||
|
|
||
| from dimos.core.core import rpc | ||
| from dimos.core.module import Module | ||
| from dimos.core.stream import In | ||
| from dimos.teleop.webxr.body_tracking import BodyTrackingSnapshot | ||
| from dimos.utils.logging_config import setup_logger | ||
|
|
||
| logger = setup_logger() | ||
|
|
||
| REPORT_INTERVAL_S = 5.0 | ||
|
|
||
|
|
||
| def body_tracking_summary( | ||
| snapshot: BodyTrackingSnapshot, | ||
| *, | ||
| snapshot_rate_hz: float, | ||
| resolved_joint_ever_seen: bool, | ||
| ) -> dict[str, Any]: | ||
| """Build one compact body-tracking health summary.""" | ||
| joints = snapshot.joints | ||
| state = "unavailable" if joints is None else "empty" if not joints else "tracking" | ||
| positions: dict[str, tuple[float, float, float]] = {} | ||
| if joints: | ||
| positions = { | ||
| name: ( | ||
| round(pose.position[0], 3), | ||
| round(pose.position[1], 3), | ||
| round(pose.position[2], 3), | ||
| ) | ||
| for name, pose in joints.items() | ||
| } | ||
|
|
||
| return { | ||
| "snapshot_rate_hz": round(snapshot_rate_hz, 1), | ||
| "state": state, | ||
| "reference_space": snapshot.frame_id, | ||
| "resolved_joint_count": 0 if joints is None else len(joints), | ||
| "resolved_joint_ever_seen": resolved_joint_ever_seen, | ||
| "joint_positions": positions, | ||
| } | ||
|
|
||
|
|
||
| class BodyTrackingMonitor(Module): | ||
| """Report live PICO body-tracking availability, rate, and joint poses.""" | ||
|
|
||
| body_tracking: In[BodyTrackingSnapshot] | ||
|
|
||
| def __init__(self, **kwargs: Any) -> None: | ||
| super().__init__(**kwargs) | ||
| self._report_started_at = monotonic() | ||
| self._snapshots_since_report = 0 | ||
| self._resolved_joint_ever_seen = False | ||
|
|
||
| @rpc | ||
| def start(self) -> None: | ||
| super().start() | ||
| self.register_disposable(Disposable(self.body_tracking.subscribe(self._on_body_tracking))) | ||
|
|
||
| def _on_body_tracking(self, snapshot: BodyTrackingSnapshot) -> None: | ||
| self._snapshots_since_report += 1 | ||
| if snapshot.joints and not self._resolved_joint_ever_seen: | ||
| self._resolved_joint_ever_seen = True | ||
| logger.info( | ||
| "WebXR body tracking acquired", | ||
| reference_space=snapshot.frame_id, | ||
| resolved_joint_count=len(snapshot.joints), | ||
| ) | ||
|
|
||
| now = monotonic() | ||
| elapsed = now - self._report_started_at | ||
| if elapsed < REPORT_INTERVAL_S: | ||
| return | ||
|
|
||
| summary = body_tracking_summary( | ||
| snapshot, | ||
| snapshot_rate_hz=self._snapshots_since_report / elapsed, | ||
| resolved_joint_ever_seen=self._resolved_joint_ever_seen, | ||
| ) | ||
| if snapshot.joints: | ||
| logger.info("WebXR body tracking health", **summary) | ||
| else: | ||
| logger.warning("WebXR body tracking has no resolved joints", **summary) | ||
| self._report_started_at = now | ||
| self._snapshots_since_report = 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.