refactor(sim): route MuJoCo control through module ports - #3682
Draft
TomCC7 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3682 +/- ##
==========================================
+ Coverage 77.74% 77.79% +0.05%
==========================================
Files 1286 1286
Lines 123225 122325 -900
Branches 10818 10751 -67
==========================================
- Hits 95801 95166 -635
+ Misses 24291 24057 -234
+ Partials 3133 3102 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture
The coordinator keeps the synchronous hardware-adapter interface needed by the control loop. The connection module holds the latest command, applies it on each physics step, and publishes state through ordinary DimOS streams. Transport selection remains a blueprint/runtime concern.
Manual test
Until #3617 lands, select Zenoh explicitly:
The existing keyboard controls should work without a simulator-specific teleop path.
Validation
./bin/pytest-fast: 4,554 passed, 33 skipped; the only failure was the blueprint generator's expected dirty-worktree checkruff check,ruff format --check,compileall, andgit diff --check: passedcargo check --manifest-path native/rust/dimos-module/Cargo.toml: passedDependency
This stacks with #3617, which changes the default transport to Zenoh. This PR does not duplicate that default change.
Addresses #3671.