Skip to content

Add Mac to tests matrix - #3681

Draft
Dreamsorcerer wants to merge 2 commits into
mainfrom
sam/mac-tests
Draft

Add Mac to tests matrix#3681
Dreamsorcerer wants to merge 2 commits into
mainfrom
sam/mac-tests

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Collaborator

This adds Mac to the regular tests matrix.

@Dreamsorcerer
Dreamsorcerer marked this pull request as draft August 25, 2026 15:37
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3681      +/-   ##
==========================================
- Coverage   77.71%   77.71%   -0.01%     
==========================================
  Files        1286     1286              
  Lines      123290   123290              
  Branches    10818    10818              
==========================================
- Hits        95815    95813       -2     
- Misses      24343    24346       +3     
+ Partials     3132     3131       -1     
Flag Coverage Δ
OS-ubuntu-24.04-arm 72.67% <ø> (-0.01%) ⬇️
OS-ubuntu-latest 74.52% <ø> (ø)
Py-3.10 74.52% <ø> (-0.01%) ⬇️
Py-3.11 74.52% <ø> (-0.01%) ⬇️
Py-3.12 74.52% <ø> (-0.01%) ⬇️
Py-3.13 74.52% <ø> (ø)
Py-3.14 74.52% <ø> (-0.01%) ⬇️
Py-3.14t 74.52% <ø> (-0.01%) ⬇️
SelfHosted-Large 30.00% <ø> (ø)
SelfHosted-Linux 35.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This change adds macOS to the regular Python test matrix. The macOS jobs currently install PortAudio but not the TurboJPEG runtime required by selected relay image tests; constructing the JPEG encoder fails when that native library is unavailable. Install the macOS TurboJPEG package alongside PortAudio before running the test suite.

Confidence Score: 4/5

Not merge-safe until the macOS test environment installs the native TurboJPEG library required by the selected tests.

One verified non-security P1 finding remains. The executed PyTurboJPEG reproduction observed the same missing-library RuntimeError expected from the macOS configuration.

Files Needing Attention: .github/workflows/ci.yml:431 needs the macOS TurboJPEG dependency added alongside PortAudio.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex produced a proof for the posted P1 finding.
  • The proof was reviewed against the related review comment to confirm the validation context.
  • Two log artifacts were attached to the proof to enable review of the macOS CI path and the PyTurboJPEG usage.

View all artifacts

T-Rex Ran code and verified through T-Rex

Comments Outside Diff (1)

  1. .github/workflows/ci.yml, line 431 (link)

    P1 macOS misses required TurboJPEG library

    The new macOS matrix installs only portaudio, but the regular test command still includes relay bridge tests that publish color_image messages. Those tests construct TurboJPEG() through the JPEG encoder, and PyTurboJPEG raises RuntimeError: Unable to locate turbojpeg library automatically when the native TurboJPEG library is absent. Install the macOS TurboJPEG package alongside PortAudio (for example, brew install portaudio libjpeg-turbo) so every newly added macOS job can run the selected tests.

    Artifacts

    macOS CI selection and relay JPEG call path

    • Captured workflow and source-line inspection showing macOS installs only PortAudio while the default test selector reaches the relay JPEG encoder.

    PyTurboJPEG without native library

    • Captured execution of PyTurboJPEG 1.8.2 without a discoverable TurboJPEG library, showing automatic construction raises RuntimeError.

    View artifacts

    T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Add Mac to tests matrix" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant