Skip to content

fix remote name - #3665

Open
paul-nechifor wants to merge 1 commit into
mainfrom
paul/fix/remote-name
Open

fix remote name#3665
paul-nechifor wants to merge 1 commit into
mainfrom
paul/fix/remote-name

Conversation

@paul-nechifor

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
- Coverage   77.29%   77.28%   -0.02%     
==========================================
  Files        1268     1269       +1     
  Lines      120892   120924      +32     
  Branches    10670    10678       +8     
==========================================
+ Hits        93444    93455      +11     
- Misses      24379    24400      +21     
  Partials     3069     3069              
Flag Coverage Δ
OS-ubuntu-24.04-arm 72.20% <100.00%> (-0.02%) ⬇️
OS-ubuntu-latest 74.09% <100.00%> (-0.01%) ⬇️
Py-3.10 74.09% <100.00%> (-0.02%) ⬇️
Py-3.11 74.09% <100.00%> (-0.02%) ⬇️
Py-3.12 74.09% <100.00%> (-0.01%) ⬇️
Py-3.13 74.09% <100.00%> (-0.02%) ⬇️
Py-3.14 74.09% <100.00%> (-0.02%) ⬇️
Py-3.14t 74.09% <100.00%> (-0.01%) ⬇️
SelfHosted-Large 30.01% <100.00%> (+<0.01%) ⬆️
SelfHosted-Linux 35.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/core/coordination/module_coordinator.py 86.56% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This change updates module shutdown logging to identify each deployed module by its remote RPC name rather than the coordinator’s internal map key.

The shutdown path was exercised with a concrete RPC client whose remote name differed from its map key. Both updated log messages reported the remote name, the stop request was sent to the expected remote RPC topic, and worker-manager shutdown completed successfully. The concern that deployed proxies might not provide remote_name, or that the logging change could disrupt shutdown, was disproved by this execution.

Confidence Score: 5/5

Safe to merge: the changed shutdown path preserves RPC stop behavior while logging the deployed module’s actual remote identity.

No actionable defects remain after exercising shutdown with a concrete deployed RPC proxy whose map key and remote name differ.

Files Needing Attention: No additional files need attention.

T-Rex T-Rex Logs

What T-Rex did

  • After the change, the shutdown logs reflect the remote name robot-7/navigation in both messages, the RPC stop call targets robot-7/navigation/stop, the worker manager stops, and the process exits successfully.
  • Before the change, the concrete RPCClient.remote_name was robot-7/navigation, while the shutdown log labels used the unrelated map key map-key-not-rpc-topic; the RPC stop call still targeted robot-7/navigation/stop.
  • The focused shutdown harness was run with a concrete RPCClient proxy to exercise remote name handling and ensure shutdown path remains intact.

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
dimos/core/coordination/module_coordinator.py Uses the deployed RPC proxy's remote name for both module shutdown log messages.

Reviews (1): Last reviewed commit: "fix remote name" | Re-trigger Greptile

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant