Skip to content

feat: add the type-checking check: dynamically typed code is type checked - #121

Merged
lefticus merged 1 commit into
static-analysisfrom
type-checking
Nov 6, 2026
Merged

lefticus merged 1 commit into
static-analysisfrom
type-checking

Conversation

@lefticus

@lefticus lefticus commented Nov 6, 2026

Copy link
Copy Markdown
Member

Closes #57. Phase 3 of #107. Stacked on #120.

A new TypeChecking rule supplies an ecosystem's type checkers and says where its strict mode is enabled. The checkers reuse Analyzer from #120.

  • Python: mypy, pyright or basedpyright, pyrefly, or ty, run in CI or as a pre-commit hook.
  • Strict mode is a bonus: strict = true for mypy, mypy --strict, or pyright's typeCheckingMode set to strict. Without it the check suggests enabling it.
  • Compiled ecosystems supply no rule, so they are skipped.

This repository passes with the bonus (strict mypy).

🤖 Generated with Claude Code

…cked

A new TypeChecking rule lists an ecosystem's type checkers (as Analyzers)
and where its strict mode is enabled. Python accepts mypy, pyright or
basedpyright, pyrefly and ty, in CI or as a pre-commit hook; strict mode
is a bonus. Compiled ecosystems supply no rule, so they are skipped.

Analyzer gains the helpers static-analysis and type-checking share, and
text.joined lists names as a sentence does.

This project already runs mypy in strict mode; the Python fixture now
does too.

Closes #57

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.45%. Comparing base (4753c68) to head (ef7863d).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           static-analysis     #121      +/-   ##
===================================================
+ Coverage            98.42%   98.45%   +0.02%     
===================================================
  Files                   55       56       +1     
  Lines                 2162     2199      +37     
  Branches               215      221       +6     
===================================================
+ Hits                  2128     2165      +37     
  Misses                  28       28              
  Partials                 6        6              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lefticus
lefticus added this pull request to stack #123 November 6, 2026 06:00
@lefticus
lefticus merged commit 017a917 into main Nov 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type-checking check: dynamically typed code is statically type checked

1 participant