Repository navigation
feat: add the dependency-management check, and hash-lock this project's CI tools - #122
Merged
Merged
Conversation
…'s CI tools A new DependencyManagement rule says how an ecosystem's dependencies are declared and where they are locked. C/C++ looks for CPM, FetchContent, vcpkg, Conan or Meson wraps; Python wants declared dependencies locked by a committed lockfile or hash-pinned requirements; Rust wants a binary crate to commit Cargo.lock; Go wants go.sum when go.mod requires modules. Every ecosystem warns when third-party code is committed (third_party/, vendor/, git submodules, ...), except go mod vendor's output. Context.tracked_files caches git's list of files, so a check can ask what is committed. This project's CI tools are now locked: .github/requirements/<job>.in names them, pip-compile --generate-hashes pins <job>.txt with every dependency's hash, and CI installs them with --require-hashes. Closes #24 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
27 of 61 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## type-checking #122 +/- ##
=================================================
+ Coverage 98.45% 98.51% +0.06%
=================================================
Files 56 58 +2
Lines 2199 2297 +98
Branches 221 231 +10
=================================================
+ Hits 2165 2263 +98
Misses 28 28
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24. Phase 3 of #107. Stacked on #121.
A new
DependencyManagementrule says how an ecosystem's dependencies are declared and where they are locked.uv.lock,poetry.lock,pdm.lock,Pipfile.lockorpylock.toml, or by hash-pinned requirementsCargo.lock(a library need not)go.sumis committed whengo.modrequires modulesThe check passes with a note when no dependencies are declared. It warns when dependencies are not locked, or when third-party code is committed (
third_party/,vendor/, git submodules, …).go mod vendoroutput does not count as committed third-party code.Decision from #107: this repository locks its development tools rather than exempting libraries.
.github/requirements/<job>.innames each job's tools.pip-compile --generate-hashespins<job>.txt, including every dependency's hash.--require-hashes.Every lock installs in a fresh venv with
--require-hashes, and pip-audit over all of them finds no known vulnerabilities.🤖 Generated with Claude Code