Repository navigation
feat: integrate native final service shutdown - #20
Merged
Merged
Conversation
This was referenced Oct 23, 2026
brianvarskonst
marked this pull request as ready for review
October 23, 2026 23:15
brianvarskonst
force-pushed
the
feat/native-service-shutdown-20261023
branch
from
October 23, 2026 23:17
ac2b541 to
73b8753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WordPress App now integrates native final service shutdown when the installed Symfony resetter supports ShutdownInterface. After WordPress shutdown actions, a weak PHP shutdown callback closes the kernel; explicit shutdown remains idempotent. Bundles shut down in reverse order, cleanup continues after errors, and a failed post-boot hook rolls back the native kernel before retry.
Autoconfiguration adapts existing reset tags for native ShutdownInterface services, preserving explicit flag/only attributes and deduplicating callbacks. Symfony owns reset execution, validation, lazy-service handling and non-shared tracking. DependencyInjection 8.1 remains supported without enabling this new integration.
Validation: complete PHPCS/PHPStan/PHPUnit QA on stable Symfony 8.1 and separately installed official 8.2/Contracts snapshots (96 tests; native 436 assertions), including the existing CLI/FPM fixture. Native regressions cover private services, initialized/uninitialized lazy services, non-shared instances, ordinary versus final resets, one-time execution, reentrancy, failure continuation, real PHP shutdown, and failing-boot-hook/retry. Seven PHPUnit notices remain visible; no tests/checks were suppressed.
Draft release blockers:
Tracking chat: 01a16a95-4440-7222-9b20-b15e4c4db9de. Related CLI completion work is in SymPress/cli. Runtime's PHP-only Composer-host/pre-autoload process boundary remains unchanged.