Skip to content

fix: preserve live kernel during container diagnostics - #12

Merged
brianvarskonst merged 1 commit into
mainfrom
fix/preserve-live-kernel-diagnostics-20261023
Oct 23, 2026
Merged

brianvarskonst merged 1 commit into
mainfrom
fix/preserve-live-kernel-diagnostics-20261023

Conversation

@brianvarskonst

Copy link
Copy Markdown
Member

Running lint:container or another diagnostic command against a booted application rebuilt configuration on the live kernel, replacing its active container and bundle instances. A later shutdown could then reach unbooted Doctrine bundles and fail instead of closing resources.

Clone the kernel before building diagnostics. The active container, compiled runtime and booted bundles retain their identities and their normal shutdown callbacks. This is compatible with stable Symfony 8.1 and does not change dependency floors or cache/backend protocols.

Validation:

  • The new real-kernel regression fails against the original trait and passes with the fix (live container/runtime/bundles preserved; shutdown called once).
  • Full PHPCS/PHPStan/PHPUnit QA: 78 tests, 367 assertions; four existing opt-in backend smoke tests remain skipped. No backend/drop-in code changed.
  • Composite Framework/Doctrine/Mailer qualification with the separate native Symfony 8.2 test installation: container lint, cache reset, SQLite operations and final connection closure pass; disabled mail delivery remains disabled.
  • Strict Composer validation, locked audit, final-head independent review and hosted CI are checked before merge.

Prepare compatible patch release v1.0.8. Tracking chat: 01a16a95-4440-7222-9b20-b15e4c4db9de. Related future-API drafts: SymPress/cli#7 and SymPress/kernel#20.

@brianvarskonst
brianvarskonst merged commit 574362f into main Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant