Repository navigation
Queue UX: channel and inbox queues act through each recipient's owner like the DM view - #1417
Merged
Merged
Conversation
…DM view BusQueueSource no longer inherits a read-only parent: its send-now and clear ask the owner of every recipient that has not yet taken a visible message (DeliveryProgress.consumed), through Core's declared owner requests. The family's actions take the captured QueueEvidence, so the popup acts on what it showed. The read-only member survives only as NoQueueSource, the source a chat view holds before its wire source arrives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdttfQjtizEYZGek9Gh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at c61b5c0 blocks on 5 lines: Warn-only, never blocks (2) |
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1 commit, 5 files. This is the Toad half of Tristan's queue unification: channel and CLI-inbox queues get the DM view's send-now and clear. The Core half is agent-comms#3883, which must merge first because this PR imports its
QueueActionRuntimeRequest.Before / after
BusQueueSourceno longer inherits a read-only parent. Send-now and clear go to every recipient still holding a visible message, meaning itsDeliveryProgress.consumedis false. The newNotificationStatus.queued_recipientsanswers that: empty by default, and the checked status lists unconsumed recipients. Each owner is asked through Core's declaredsend_now/clear_queuerequests (QueueActionRuntimeRequest.at_owner). A refusal names each recipient that refused.QueueEvidence, the same captured read the popup displays, instead of only the presentation.QueueEvidencegainsservice, the view's Core service, read at action time.CommsChatViewholdsNoQueueSourceuntil itsWireSourcearrives.Evidence
toad.submission_queue,toad.screens.queue,toad.widgets.comms_chat,toad.session_presentation,toad.conversation_submissionimport cleanly against agent-comms#3883.tests/textual/test_message_notifications.py test_message_notification_title.py test_queue_inspection.py test_wire_message_lines.py: 5 passed and 8 failed, with the same 8 failing on main in this container. All 8 raiseGitVersionUnsupportedbecause the container has Git 2.43 and Core requires 2.44. So the app-level tests are unrun here.Still to do on this overhaul
MessagePrompt.sync_turnis a no-op, andSubmitNowAction.availableasks ACP readiness instead of the source capability. Ctrl+Enter / Ctrl+Y and the inline queue controls should askqueue_source.queue_actions_available.queue-operationenqueue/dequeue/remove). Core's bridge declares that record but keeps none of its fields (claude_protocol.py:1152). The inbox should show that queue through this same source.Assumed: clearing a channel recipient's queue clears that agent's whole queue, the same queue the DM view clears, not only this channel's items. Per-item withdrawal uses the existing ID-targeted cancel later.
Generated by Claude Code