Skip to content

Integrate the existing coupled submission sources - #1407

Closed
trissim wants to merge 34 commits into
mainfrom
batch/pi-toad-errors-submission
Closed

trissim wants to merge 34 commits into
mainfrom
batch/pi-toad-errors-submission

Conversation

@trissim

@trissim trissim commented Nov 2, 2026 •

Copy link
Copy Markdown

P1090: preserve original submission and project identities

Captured source cut

Existing coupled carriers: Core#3857 / Toad#1407. Source changes remain documented on Core#3848 and Toad#1389.

  • Core source: a325863122dffc0f68dddaf399343c3aa3187a78, 21 files, +274/-92.
  • Toad source: e7e409268d3469f697f0a69149933f529dca11b0, 73 files, +2796/-1782.
  • Core substantive carrier: f45f37216e964af3bba2d7db7609bfe7d8f8077c.
  • Toad resolved carrier: ebaad6cf6633141c3a06b8671ee0287bd6a3330f.
  • Native captured commit: 6464ef0951b7aff41d3526c57254b6ae4533206c.
  • Input digest: df52ab29efb66c89fb67a455b2cfed01d6639c4b63a160271912eb4142ea98c6.
  • Baselines: Core ed110cc79cb4bf44964b85e1f41c241ae71880e3; Toad 51cf2655dd50b5b32bb707fcfacda56381c2eae3; Textual da87b77f22bd032bf7cd6d52630f684fa4a2b320. The input also records the declared formbridge, metaclass-registry and ui-theme sources.

The installed supported producer captured actual P1090 and its order-linked source heads, using the real existing carrier PRs. Output: /home/ts/wt/pi-toad-errors--7425ce3d67d94062967e2f4208730b62--p1090-capture-03/input.json. It returned QUALIFICATION ONLY; no review or merge permission. No execution result is inferred from that record.

Mechanisms

ThreadManagement refuses replacement ThreadIncarnation before path work. Toad captures original request/source/session across awaits; queue capability, acknowledgement, local draft intent, physical writer and cancelled waiter stay separate. SessionViewState preserves editor document and undo through eviction. Joined writer and transport lifetime retain sibling usability after a rejected close. Existing request/controller SDK ContentBlock and shared control-text carrier remain, without a cast or second decoder.

Acquired ACP destination, canonical history name and saved SDK resume spelling remain distinct. The last correction uses the original response.session_id at both DB persistence calls, keeping strict validation unchanged. Automatic title policy comes from attachment; the actual observed_thread metadata API and its project/rename consumers remain.

Shared worker context lives in CoordinationWork and is inherited by Coordination and SessionLoadPlan, removing the aggregate import cycle. ThreadInterest owns the publisher capability, existing MessageId survives notification annotations, and ResourceRelease owns Timer.stop. The removed conversation handler module's existing bodies now belong to Conversation; deletion alone is not a dispatch-parity claim.

Retained evidence and failures

Latest title/resume/project epoch: 5 collected / 5 executed / 5 passed, 68.03s pytest, 71.322s controller, rc0. It includes new/existing saved-row branches and three actual project/rename/replacement cases. Exact pre-publication sources and patch are recorded; this is selected execution, not the captured union or installed acceptance.

Earlier independent epochs remain separate: load-plan/maintenance 6/6; publisher app controls 3/3; selected publisher typing 0 errors/3 files; acquired-binding controls 9/9; BUS controls 2/2. Original failed import/type/startup epochs, combined timeout, native-image pre-I/O refusal and every original failed root remain retained. No aggregate all-green claim combines these runs.

Capture attempt01 refused an output path inside the source checkout before preparation. Attempt02 refused untracked diagnostic state before preparation. A supported clean P1090 checkout fixed that prerequisite without moving or deleting original roots. Attempt03 completed as recorded above. All logs are retained in /home/ts/.cache/agent-scratch/pi-toad-errors/delivery-owned/.

Preservation and remaining acceptance

Old carrier commits 6e93291c02405d731e78737dec1b416e241819ea and e346f80d88f2c63fb690f0f08a766c9e258fffba remain under owned archive/p1090-before-rebuild-01 refs. Existing source PRs and all useful composed corrections are retained. No new PR, borrowed worktree edit, original-input replay, metadata clearing or producer overlay was used.

Open: exact source judgments, captured touched-test union, compatible merge, supported relock/install, and the observed installed submission/project/draft/undo/queued-input/sibling journey. Native-image and physical acceptance remain explicitly unfinished. Current installed ed110/51cf/da87 excludes P1090.

Assumed: Python3.14 native annotation lifecycle; raw SDK packets stay foreign until matched/decoded at the existing inlet. Source tracing and selected executions do not substitute for qualification, merge or installed behavior.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 08:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Keep actual SDK completion, failed reply and unconfirmed transport distinct on captured requests. Share confirmed settlement through SendState, use InputDecision for native admission, and delete nullable turn/compaction recovery. Correct real-worker, settings and held-resource controls; no unit pytest or UI run. NRA map1349 modules plus11-module extension;641 compile and SDK/MRO/five fresh imports pass.
@trissim
trissim force-pushed the batch/pi-toad-errors-submission branch from e346f80 to ebaad6c Compare November 2, 2026 13:23

trissim commented Nov 2, 2026

Copy link
Copy Markdown
Author

Closed in Tristan's board clear (2026-11-02): an integration carrier superseded by #1389, with the queue UX landed in #1417. The branch is kept.


Generated by Claude Code

@trissim trissim closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants