Repository navigation
P957: show recorded service health in the open commander header - #1335
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 29, 2026 22:18
trissim
added a commit
that referenced
this pull request
Oct 29, 2026
Revert #1335 until Core #3617 lands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P957 urgent companion: one header, not two policies
1 commit; 2 files, +20/-10 against current main. Paired with OpenHCSDev/agent-comms#3617. Original Core #3609 remains preserved/deferred; frozen ToAD #1321 is untouched.
Before → after
CommanderFrameView.presentcomposed load and heartbeat age itself, dropping Core's recorded service failure. It now consumeshud.header, the same behavior used by Core HUD/load. The unused local time import and direct header composition are deleted (5 production lines removed).Core owns recorded error/age/completion/stale status and the service-file observation dependency. This view paints that answer; it does not keep another health store or clock.
Root-only selector and acceptance
tests/textual/test_commander_page.py::test_commander_page_survives_unreadable_frames_and_recoversnow includes a service-only failure/recovery while the frame file stays unchanged and the open disclosure/focus remain retained. Constructor uses named fields for the inherited Core load owner.UNRUN: no author tests, checker, import probe, environment, GUI or provider execution. Root must qualify against the matched Core head and exercise actual installed failure/recovery with the board already open. The file-only presentation control is not proof of a successful native service pass.
Assumed: root records the qualified companion link and performs combined qualification/installation; no source or application acceptance claimed.