Skip to content

Revert #1335 until Core #3617 lands - #1339

Merged
trissim merged 1 commit into
mainfrom
revert/1335-before-core-3617
Oct 29, 2026
Merged

trissim merged 1 commit into
mainfrom
revert/1335-before-core-3617

Conversation

@trissim

@trissim trissim commented Oct 29, 2026

Copy link
Copy Markdown

toad#1335 merged at 23:19 (6dafc0e) while its Core half, agent-comms#3617 (CommanderLoad.header), is still open and sent back.

Breakage: Toad main's src/toad/screens/commander.py:207 calls hud.header, but Core main has no header on the HUD (git grep 'def header' origin/main finds only exporting/native entries). Any install of Toad main raises AttributeError as soon as the commander page opens.

Change: a plain revert of the merge commit (2 files, +10/-20).

Re-land: hud-repair-pi re-lands the Toad half in the same batch as #3617.

How it happened: the OK verdict on #1335 auto-requested the merge, and Toad CI does not exercise the commander page against Core main.

🤖 Generated with Claude Code

…main lacks

toad#1335 merged at 23:19 while its Core half, agent-comms#3617 (CommanderLoad.header),
is still open and sent back. Toad main's screens/commander.py:207 therefore raises
AttributeError the moment the commander page opens on any install of Toad main.
hud-repair-pi re-lands the Toad half together with #3617.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK
Copilot AI balanced review requested due to automatic review settings October 29, 2026 23:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit 0312fc4 into main Oct 29, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants