Skip to content

Keep declaration failures visible during field preparation - #24

Merged
trissim merged 1 commit into
mainfrom
fix/declaration-owned-fields
Oct 16, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/declaration-owned-fields

Conversation

@trissim

@trissim trissim commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

What changed

The existing SignatureAnalyzer cache now receives resolved dataclass annotations only. Unknown types and failing default factories propagate instead of silently producing an empty form. Recursive owner annotations resolve even before a decorator binds the class in its module.

Why this owner

ObjectState field behavior must come from declarations, not runtime probes. Its declaration preparation cannot safely build on an analyser that fabricates an empty result. This repairs that existing owner; no second analyser or cache was added.

Checked

  • Actual UnifiedParameterAnalyzer API: recursive declaration, cache reuse, literal null, unknown annotation failure, original factory exception identity.
  • 63 focused tests passed across declaration failures, annotation types, signature analysis and unified analysis.
  • No package installation or full application claim. ObjectState/FormBridge declaration-based value redesign remains unfinished.

@trissim
trissim marked this pull request as ready for review October 16, 2026 18:27
Copilot AI balanced review requested due to automatic review settings October 16, 2026 18:27
@trissim
trissim merged commit 0aff2a7 into main Oct 16, 2026
3 of 15 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants