Repository navigation
Include inline typing metadata in distributions - #26
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python type checkers currently treat the installed python-introspect package as untyped because its distributions omit the inline typing marker. Add the empty package marker and declare it as setuptools package data so wheel and source distributions carry it.
Validation: built both distributions with the repository setuptools backend, then inspected the wheel ZIP and source tarball. Both contain the empty python_introspect/py.typed marker. Source diff check passed; no runtime code changed.
The existing retry test expected empty output from a throwing dataclass factory, although merged #24 deliberately propagates that exception. Exact base CI failed the same single control. Update its two expectations to the existing exception contract while preserving no preparation-time execution, uncached failure and retry counts.
Focused validation: factory retry, exception identity and preparation timing all passed (3 controls). Wheel and source-tar marker contents were inspected.