Repository navigation
NRA gate findings: one shared action posts the blocking verdict on the PR - #3880
Merged
Merged
Conversation
…e PR The gate's pull request comment moves from an inline nra-gate.yml step into .github/actions/nra-findings, which agent-comms uses beside its tree and Toad uses from the Core checkout its gate already runs from. The comment carries only the gate's verdict lines: grew/found/introduced/missing for blocking measures first, then warn-only measures (those NRA marks "warns, never blocks", such as Unformatted and LintFindings) in a collapsed section. Installer chatter such as the CommandPhase/uv build lines is dropped. A passing run rewrites a comment an earlier red run left, so a stale red comment no longer outlives its fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdttfQjtizEYZGek9Gh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at 8183725 passes. |
|
debt-tools at 8183725 passes. |
… spelling The gate itself flagged render.py for StringIdentity (outcome == "success"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdttfQjtizEYZGek9Gh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-reporting hotfix. A red NRA gate should say why on its pull request, so nobody has to download a 450 KB job log to find out.
nra-gate.ymlmoves into.github/actions/nra-findings. The action is the single owner of the gate's PR comment. Agent-comms uses it beside its tree (./.github/actions/nra-findings). Toad uses it from the Core checkout its gate already runs from (./.core-gate/.github/actions/nra-findings), so the comment and the gate always come from the same Core commit.grew/found/introduced/missinglines first. Warn-only measures (the ones NRA marks(warns, never blocks), such as Unformatted, LintFindings and GodClassExcess) go in a collapsed section. Installer noise such as+ CommandPhase ... uv buildis dropped. If the gate fails without printing a verdict (a crash), the comment shows the last 40 stderr lines instead.<!-- $KIND findings -->marker, and each run replaces it. A passing run rewrites a comment that an earlier red run left. It never opens a new one.The proof will be in the paired Toad PR's own run. Agent-comms' gates do not measure
.github/, so this PR's own debt gates pass and post nothing.Generated by Claude Code