Repository navigation
NRA gate: post the gate's findings on the pull request - #1413
Merged
Merged
Conversation
The NRA gate job kept its verdict lines only in a ~1 MB job log. It now captures the gate's stderr and hands it to Core's shared .github/actions/nra-findings action, from the same .core-gate checkout the gate runs from, which upserts one "<!-- debt-src findings -->" comment with the blocking lines first and warn-only ones apart. The job gets pull-requests: write for that comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdttfQjtizEYZGek9Gh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdttfQjtizEYZGek9Gh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at 7d34cbd passes. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdttfQjtizEYZGek9Gh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-reporting hotfix. Today a red "NRA gate" job keeps its verdict only in a job log of about 1 MB.
gate-findings.txtand still echoes it to the log..github/actions/nra-findingsaction (NRA gate findings: one shared action posts the blocking verdict on the PR agent-comms#3880). The action is loaded from the same.core-gatecheckout the gate runs from. It upserts one<!-- debt-src findings -->comment: blocking lines first, then the warn-only lines (Unformatted, LintFindings, GodClassExcess) in a collapsed section.pull-requests: writeso it can post the comment.To prove it on this PR's own run, the second commit makes the gate red on purpose in
src/toad/platform.py. It adds a TYPE_CHECKING import, a type error and unsorted imports. A revert commit follows once the comment is seen, so the net diff is only.github/workflows/ci.yml.Generated by Claude Code