Repository navigation
Conversation
Keep consolidation locked until the registered background agent reaches a terminal state. Record success only after completion and a successful state write; release the lock on launch failure, task failure, cancellation, or revoked goal authority. Coven-Harness: Codex / GPT-6
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 18, 2026
Member
Author
|
Holding this PR for the completion-contract findings in #374. Registry Cancelled is a cancellation request, not proof that the agent has exited; #365 signals cancellation but does not acknowledge exit. finish_after_launch also stamps successful consolidation for MaxTokens because AgentTool maps that outcome to Completed. Please use a typed execution-completion signal and retain lock ownership through cancellation/cleanup, with delayed-cleanup and partial-response regressions. Full source-level evidence and acceptance criteria are in #374. |
This was referenced Oct 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #397, which addresses the ownership and completion findings in #374. The replacement passes local formatting, workspace check, strict Clippy, the full serial workspace suite, and all eight hosted checks at
0aa9388. Closing this proposal without merging; #397 retains the v0.9.0 hold and #374 remains open until delivery.Summary
Context
claurst-queryAutoDream lifecycle and its query-loop call site.Changes
Validation
All Cargo commands used
COVEN_HOMEandCOVEN_CAVE_HOMEunder/tmp,CARGO_INCREMENTAL=0, and a single serialized target directory under/tmp.git diff --check— passed.cargo fmt --allandcargo fmt --all -- --check— passed.cargo check --workspace --all-targets --locked— passed.cargo clippy --workspace --all-targets --locked -- -D warnings— passed.cargo test --workspace --locked— passed.cargo test -p claurst-query auto_dream::tests --locked— 12 passed. The failed-state-write regression failed against the original behavior before the fix.PR Readiness
AgentToolclassifies max-token partial turns asCompleted, so AutoDream cannot distinguish that result from a finished turn. On current main, monitor cancellation can mark a taskCancelledbefore its agent exits; fix(query): stop background agent on monitor cancellation #365 addresses execution cancellation, so lock release at that status still has a window until it lands. The existing one-hour stale-lock rule and cross-process lock acquisition are unchanged. A separate review should decide those contracts before changing them.