Repository navigation
fix(query): stop background agent on monitor cancellation - #365
Merged
Merged
Conversation
Coven-Harness: Codex / GPT-6
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 18, 2026
Member
Author
|
Reviewed task registry cancellation and the background agent producer, including the local HTTP cancellation regression and terminal-state control. All eight head checks passed; whitespace and merge-tree checks passed after #357 landed. Composition retains the Debug redaction and adds only the reviewed runtime token changes to core. Registry cancellation signals execution; it is not a cleanup-completion receipt. #366 remains blocked on #374. Verification relies on hosted Rust checks; no fresh local Cargo run was performed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
AgentTooltasks and the task registry's terminal cancellation transition.Changes
Validation
git diff --check: passed.cargo fmt --all -- --check: passed.CARGO_TARGET_DIR=/tmp/coven-code-goal3-acp-target cargo test --package claurst-core --test task_terminal --locked: passed.CARGO_TARGET_DIR=/tmp/coven-code-goal3-acp-target cargo test --package claurst-query --lib monitor_cancel_stops_background_agent_request --locked: passed; failed before the code change.CARGO_TARGET_DIR=/tmp/coven-code-goal3-acp-target cargo check --workspace --all-targets --locked: passed.CARGO_TARGET_DIR=/tmp/coven-code-goal3-acp-target cargo clippy --workspace --all-targets --locked -- -D warnings: passed.CARGO_TARGET_DIR=/tmp/coven-code-goal3-acp-target cargo test --workspace --locked: passed.scripts/tui-tests/run.sh: N/A; no TUI or input changes.PR Readiness