Skip to content

Cape Town | 26-ITP- Sept | Leigh Ross | Sprint 3 | Refactoring Dead Code #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leigh-ross wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Cape Town | 26-ITP- Sept | Leigh Ross | Sprint 3 | Refactoring Dead Code #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
05cbf49
Moved return to the end of function
leigh-ross Oct 16, 2026
44c2ce3
Removed extra console.log() inside function and removed redundant gre…
leigh-ross Oct 16, 2026
a7912d7
Added function call inside console.log() outside function and removed…
leigh-ross Oct 16, 2026
28dd010
Added actual values instead of variables inside function call. It sho…
leigh-ross Oct 16, 2026
e75ac48
Remove redundant function logPets()
leigh-ross Oct 16, 2026
77d2d37
Add function call inside console.log() and remove unecessary var decl…
leigh-ross Oct 16, 2026
f64f9fe
Remove capitalisedPets code because it already happens inside or func…
leigh-ross Oct 16, 2026
9053cec
Remove capitalisedPets code because it already happens inside or func…
leigh-ross Oct 16, 2026
30864f3
Added variable back in and pass variable into function call
leigh-ross Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions dead-code/exercise-1.js
View file
Open in desktop

@KudahShambare KudahShambare Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for it to work on every name, you don't need to hard code Aman!

@leigh-ross leigh-ross Oct 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, not sure what you are referring to.
I had removed the testName variable in favor of passing the name as a variable .
Please check my work again.

@KudahShambare KudahShambare Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to uppercase is found both inside and outside the function, that's redudancy

@leigh-ross leigh-ross Oct 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I am not sure what you are referring to because I have deleted the redundant code.
The lines that are highlighted in red are deleted lines. Lines highlighted in green are lines I have added.
You should be able to see that I removed line 5 where the redundancy was.

Please recheck my work.

@KudahShambare KudahShambare Oct 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apollogies, on the to uppercase I might have made a mistake,

@KudahShambare KudahShambare Oct 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I had removed the testName variable in favor of passing the name as a variable ."

it is not a variable in your code, it has to be a variale, while you mantaining your goal of removing redudancy

@leigh-ross leigh-ross Oct 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see. I have made the necessary changes.
Could you please explain why the testName variable is needed instead of passing the name directly into the function call?

Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
// Find the instances of unreachable and redundant code - remove them!
// The sayHello function should continue to work for any reasonable input it's given.

let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";

const greetingMessage = sayHello(greeting, testName);
let testName = "Aman"

console.log(greetingMessage); // 'hello, Aman!'
console.log(sayHello("hello", testName));
9 changes: 1 addition & 8 deletions dead-code/exercise-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,8 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}

function countAndCapitalisePets(petsArr) {
const petCount = {};

Expand All @@ -23,6 +18,4 @@ function countAndCapitalisePets(petsArr) {
return petCount;
}

const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);

console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log
console.log(countAndCapitalisePets(petsStartingWithH)); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log
Loading