Repository navigation
Cape Town | 26-ITP- Sept | Leigh Ross | Sprint 3 | Refactoring Dead Code - #1719
leigh-ross wants to merge 9 commits into
Conversation
…eting declaration
… unnecesarry var declaration
…uld be able to still take any reasonable input
leigh-ross
added
the
Needs Review
There was a problem hiding this comment.
for it to work on every name, you don't need to hard code Aman!
There was a problem hiding this comment.
Hi there, not sure what you are referring to.
I had removed the testName variable in favor of passing the name as a variable .
Please check my work again.
There was a problem hiding this comment.
to uppercase is found both inside and outside the function, that's redudancy
There was a problem hiding this comment.
Again I am not sure what you are referring to because I have deleted the redundant code.
The lines that are highlighted in red are deleted lines. Lines highlighted in green are lines I have added.
You should be able to see that I removed line 5 where the redundancy was.
Please recheck my work.
There was a problem hiding this comment.
Apollogies, on the to uppercase I might have made a mistake,
There was a problem hiding this comment.
"I had removed the testName variable in favor of passing the name as a variable ."
it is not a variable in your code, it has to be a variale, while you mantaining your goal of removing redudancy
There was a problem hiding this comment.
Okay I see. I have made the necessary changes.
Could you please explain why the testName variable is needed instead of passing the name directly into the function call?
KudahShambare
added
Reviewed
leigh-ross
added
the
Needs Review
Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
Removed all dead code from exercise-1 and exercise-2.