Repository navigation
Conversation
spalen0
marked this pull request as ready for review
November 5, 2026 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch role grants such as Infinifi's
grantRoles(bytes32[],address[])skipped role-name resolution because the collector only inspected scalarbytes32parameters. Wrapped grants also lacked target-specific role context, while unrelated salts could inherit role labels resolved elsewhere on the same target.Resolve scalar, array, and tuple role arguments through supported timelock execution/scheduling wrappers and Yearn Executor scripts. Group mixed-case target addresses before source lookup, and carry each inner target's role names into both the prompt and call-flow report. Annotate only role functions, preserve raw payloads on decoding failures, and leave unknown-target calldata unlabelled. The Infinifi priority-hook batch now identifies
MANUAL_REBALANCERfor both hooks andFARM_SWAP_CALLERfor the long timelock. Scheduled payloads are inspected without changing the execution-only context used by protocol adapters.Validation:
mainmatchesorigin/main; its 109 corresponding tests passed, plus 2 subtests. Reproduced the bug there without modifying the checkout.