feat: support per-replica worker and GPU placement - #5286
Open
m199369309 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces per-replica placement configuration (replica_config) for model launches in Xinference, allowing users to pin individual replicas to specific workers and GPU indexes. The changes span documentation, REST API endpoints, Python clients, and supervisor scheduling logic, alongside comprehensive unit tests. The review feedback highlights an opportunity to reduce code duplication in the REST API layer by extracting the replica_config validation and parsing logic into a reusable helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replica_configlaunch option to the REST API and sync/async Python clientsn_gpu, and an alias independently for every replicahost:portworker addresses while retaining bare-host compatibility, and ignore worker pinning in local deploymentStack
This is PR 1/6 and is the backend foundation for the replica-management stack.
Validation
git diff --checkFollow-up PRs
The independent launch-model stale-request fix is #5285.