fix(config): use requested Nacos group for update listener - #957
Open
eyesofish wants to merge 1 commit into
Open
fix(config): use requested Nacos group for update listener#957eyesofish wants to merge 1 commit into
eyesofish wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the resolved
group_idwhen registering the Nacos configuration listener.create_config()already publishes to the caller-selected group, but the listener was always registered against the defaultVEADK_GROUP. As a result, configurations published to custom groups never received updates.A focused unit test verifies that publishing and listening use the same custom group.
Validation
pytestandpre-commitwere not run locally because the package registry was unreachable; CI results will be tracked on the PR