[pull] master from ruby:master - #1345
Merged
Merged
Conversation
`null?` buffer isn't MemoryView available. Not `null?` buffer is MemoryView available. It can be exported as a 1-dimensional contiguous array of bytes. Users can't change the underlying memory of the exporting IO::Buffer while exported MemoryView is using.
…elog on `gem update --system` CHANGELOG.md is over 7,000 lines of generated PR titles, and printing every entry since the previous version dominated the output (478 of the 499 lines on the ruby:3.4 image). Print a single line linking the versioned CHANGELOG.md instead. setup.rb keeps accepting --previous-version so the message can name the range to read. The link falls back to master for .dev versions, which have no tag, and the since clause is dropped when the value is missing, invalid, or not older than the installed version. Fixes ruby/rubygems#9789 ruby/rubygems@0fb09692be Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
With the changelog dump gone, the pre-update notice is where users decide whether to update, so link the versioned CHANGELOG.md there too, matching npm's three-line notice. ruby/rubygems@4ca3c9eba1 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Requester#request computes a monotonic time limit but only the socket readability wait honoured it, so a peer that sends an incomplete frame and keeps the connection open blocked past the configured timeouts until it closed. The parameter defaults to nil, which keeps the previous blocking behaviour for anyone calling recv_reply the old way. ruby/resolv@a9133ef6f3 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Giving up part way through a frame leaves the stream between frame boundaries, so reusing the cached requester made every later attempt read the previous frame's bytes as a length prefix. Asking the requester instead of its class keeps a connection whose stream is still on a boundary, which a plain timeout has no reason to throw away. ruby/resolv@791447b93f Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )