Repository navigation
Don't add an empty footnotes block when no footnote is referenced - #758
Open
RavSinghChandan wants to merge 2 commits into
Open
RavSinghChandan wants to merge 2 commits into
RavSinghChandan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
footnotesextra, a footnote that is defined but never referenced still makes markdown2 append the footnotes block, with an empty list:_add_footnoteschecksself.footnotes(the definitions) but only listsself.footnote_ids(the referenced ones), so the block is empty when nothing is referenced. It now checks the referenced ids, so the output is just<p>Text.</p>. Documents with referenced footnotes are unchanged, and unreferenced definitions were already left out of the list.Added the
footnotes_unreferencedtest case