module: generic: remove unnecessary EXPORT_SYMBOL - #11101
Open
kv2019i wants to merge 1 commit into
Open
Conversation
Remove export for mod_free_all(). It is not needed and unnecessary exports have a cost when modules are loaded. Fixes: a0939f4 ("module: generic: use a single static lock for module resources") Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 17, 2026 12:13
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the EXPORT_SYMBOL() for z_impl_mod_free_all() in the module adapter generic implementation, reducing the exported symbol surface and avoiding unnecessary module-load export costs.
Changes:
- Dropped
EXPORT_SYMBOL(z_impl_mod_free_all)fromgeneric.cwhile keeping the implementation intact.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lyakh
approved these changes
Aug 17, 2026
jsarha
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove export for mod_free_all(). It is not needed and unnecessary exports have a cost when modules are loaded.
Fixes: a0939f4 ("module: generic: use a single static lock for module resources")