Repository navigation
fix: drop all leading whitespace before the first attribute - #327
Closed
DahanItamar wants to merge 1 commit into
Closed
DahanItamar wants to merge 1 commit into
DahanItamar wants to merge 1 commit into
Conversation
The attribute capture includes the whitespace after the tag name, but only its first character was removed. When the first attribute was on a new line, the remaining indentation stayed in rawAttrs, and toString() added another space in front of it. Fixes #300. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #300.
The markup pattern captures the attributes together with the whitespace that follows the tag name, but the parser removed only its first character (
attributes.slice(1)). When the first attribute sits on its own line, the remaining indentation was kept inrawAttrs, andtoString()then added its own separating space:This strips all leading whitespace instead. Whitespace between attributes is kept as before, and markup that already had a single space before the first attribute serializes unchanged.
Validation:
test/tests/issues/300.jscoversrawAttrs, newline, tab and multi-space separators, and the unchanged single-space case. Three of its four cases failed before the fix.git diff --checkpassed. ESLint still can't initialize with the locked TypeScript installation, same as noted in fix: preserve table rows with omitted end tags #322.🤖 Generated with Claude Code