Repository navigation
Fix guidance for unverifiable licence activation requests - #1249
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
enaboapps
force-pushed
the
fix/1247-activation-error-guidance
branch
from
October 31, 2026 18:16
a8f440d to
94b5662
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rejected licence request currently tells users to connect to the internet, even when the purchase key is unregistered or the computer clock is incorrect. Classify the backend’s exact HTTP 400
invalidresponse and give key/date-time/support guidance, preserving the current trial or signed offline allowance.#1248 merged first. Rebased onto current main and retargeted to main; this PR contains only the activation-error handling and matching user guide changes. The tree is identical to the previously reviewed head a8f440d. Closes #1247.
Validation: Node 24 / Rust 1.97.1; prediction models, lint, 323 UI tests and 23 Node tests, app and docs-site builds, Rust formatting, clippy, 883 Rust unit tests and 9 configuration tests passed (4 existing ignored tests). Regression coverage checks response classification, unchanged cached entitlement on invalid renewal, and unchanged trial on invalid initial activation. No native input or installed-app tests were run.
Independent review of a8f440d found no actionable issues; response classification, entitlement preservation, tests and user guidance reviewed. Fresh independent review of rebased head 94b5662 passed with no actionable findings; tree identical to prior reviewed head. Refreshed CI pending. Owner authorized merge and pull. v1.4.0 remains held; no version/tag/release or live checkout changes.