[ImgBot] Optimize images - #4
Open
imgbot[bot] wants to merge 1 commit into
Open
Conversation
*Total -- 8,126.46kb -> 6,992.14kb (13.96%) /docs/assets/pptxdiff_demo_1_allpairs.png -- 353.32kb -> 198.36kb (43.86%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_demo_1_allpairs.png -- 353.32kb -> 198.36kb (43.86%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_batch-results.png -- 103.84kb -> 83.07kb (20%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_all-pairs-view.png -- 134.61kb -> 109.27kb (18.83%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_single-pair-view.png -- 83.17kb -> 68.23kb (17.96%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_reviewer-workflow.png -- 298.35kb -> 246.04kb (17.53%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_diff-list.png -- 294.50kb -> 243.14kb (17.44%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_export-menu.png -- 104.23kb -> 86.50kb (17.01%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_merge-preview.png -- 338.76kb -> 281.53kb (16.89%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_self-tests.png -- 55.08kb -> 46.01kb (16.47%) /src/pptxdiff/docs-site/docs/assets/img/icon_128x128.png -- 20.17kb -> 17.40kb (13.74%) /docs/assets/icon_128x128.png -- 20.17kb -> 17.40kb (13.74%) /docs/assets/pptxdiff_logo.png -- 998.29kb -> 898.00kb (10.05%) /docs/assets/icon.png -- 998.29kb -> 898.00kb (10.05%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_logo.png -- 998.29kb -> 898.00kb (10.05%) /docs/assets/pptxdiff_banner.png -- 1,075.34kb -> 973.71kb (9.45%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_banner.png -- 1,075.34kb -> 973.71kb (9.45%) /src/pptxdiff/docs-site/docs/assets/img/pptxdiff_dark-mode-toggle.gif -- 821.38kb -> 755.41kb (8.03%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
sugatoray
pushed a commit
that referenced
this pull request
Jul 31, 2026
pptxdiff-cli install-git-integration [--global] wires *.pptx into git diff/difftool in one step, completing the git-integration ticket (PLAN.md #4): appends "*.pptx diff=pptxdiff" to the repo's .gitattributes (idempotent, preserves existing content) and sets diff.pptxdiff.textconv / difftool.pptxdiff.cmd via real `git config` calls -- local by default, --global only with that explicit flag (the flag itself is the consent; this is a scriptable tool, no interactive TTY prompt). Fails clearly (exit 2) when not run inside a git repo, via `git rev-parse --show-toplevel`. lib/git-integration.js splits this the same way as the rest of the package: computeGitAttributesUpdate() and buildGitConfigCommands() are pure decision functions (idempotency, content-preservation, and argv-shape all unit-tested without touching a real repo); installGitIntegration() is the impure orchestrator, tested for real against actual temp git repos (git init, real git config calls, a real HOME override so --global testing never touches this sandbox's real ~/.gitconfig). Found and fixed one real bug via a genuine RED test failure: buildGitConfigCommands() originally put --global BEFORE "config" (`git --global config ...`), which git rejects outright with "unknown option: --global" -- git only accepts --global as a flag TO the config subcommand (`git config --global ...`). Caught by the real e2e test actually invoking git, not by reading git's docs cold; the pure unit test's own (wrong) expectation had encoded the same mistake and needed fixing alongside the implementation. 50 new assertions across 4 test files (14 pure, 14 real-e2e against temp repos, 8 real-spawned-bin end-to-end, plus 14 more folded into cli-core.js's existing suite for parseArgs/main() dispatch coverage) -- package total now 182 (was 133). README documents the actual git wiring this command performs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 14% 🎉
Details
📝 docs |
repo | 🙋🏾 issues | 🏪 marketplace
~Imgbot - Part of Optimole family