Repository navigation
Add the Sparkle update-signing public key - #261
Merged
Merged
Conversation
Release builds embed this key as SUPublicEDKey. The private key stays in Ask Key with an offline backup and never enters the repository.
|
Maintainer's in-person steps for #258 are done:
The public key in this PR is the one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258
Summary
Adds
scripts/sparkle-public-key.txt, the Ed25519 public key that Release builds embed asSUPublicEDKey(ADR 0011, decision 2). The maintainer generated the key pair in person withgenerate_keysfrom the pinned Sparkle 2.10.1 artifact. The private key is kept only in Ask Key, delivered throughaskkey runasSPARKLE_ED_KEY_FILE, with an offline backup. It is not in this repository, CI, logs or command arguments.Diff stat
Tests
python3 -m unittest Tests/Automation/test_build_app_sparkle.py: 11 run, 8 passed, 0 failed, 3 skipped. The skipped tests need a local Debug bundle, which this change does not affect.Checks
test "$(tr -d '\n' < scripts/sparkle-public-key.txt | base64 -d | wc -c | tr -d ' ')" = 32: succeeds.scripts/build-app.shrequires (^[A-Za-z0-9+/]{43}=$, 32 bytes decoded).python3 scripts/check_hygiene.py: passed.Deviations and questions
The key was generated under the keychain account
askkeyinstead of Sparkle's defaulted25519, so it cannot be confused with another project's Sparkle key. The keychain item is deleted afterwards, andsign_update --ed-key-filereads the key from the delivered file, so the account name has no lasting effect.