Skip to content

chore: adopt Rust 1.99.1 toolchain policy - #294

Merged
jan-kubica merged 3 commits into
mainfrom
chore/rust-1991-20261028
Oct 28, 2026
Merged

jan-kubica merged 3 commits into
mainfrom
chore/rust-1991-20261028

Conversation

@jan-kubica

@jan-kubica jan-kubica commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Adopt the published shared toolchain policy 3.2.1 and Rust 1.99.1 across development setup, CI, and release builds. Regenerate the cloud setup from the canonical package.

Rust 1.99.1 fixes an x86_64 FFI boolean-return miscompilation and linker regressions. Hawk retains its existing bounded compiler-private 1.97.1 exception.

Validation: dependency resolution, canonical toolchain guard, generated setup and workflow formatting passed. Existing native, WebAssembly and package checks remain required in CI.

Summary by CodeRabbit

  • Chores
    • Updated the Rust toolchain to version 1.99.1 across development setup, checks and release builds.
    • Updated a development tooling package.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@stll/oxlint-config 3.2.1 UnknownUnknown

Scanned Files

  • package.json

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0953b3b and 1ccb902.

Files selected for processing: 1
  • .github/workflows/cla.yml

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 391cb86 and 0953b3b.

Files ignored due to path filters: 1
  • bun.lock is excluded by !**/*.lock
Files selected for processing: 8
  • .agents/cloud-setup.sh
  • .changeset/rust-patch.md
  • .github/workflows/ci.yml
  • .github/workflows/mutants.yml
  • .github/workflows/release.yml
  • package.json
  • rust-toolchain.toml
  • stll-toolchain.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 9
  • GitHub Check: Lint
  • GitHub Check: Version sync
  • GitHub Check: Pack
  • GitHub Check: Changeset
  • GitHub Check: Rust
  • GitHub Check: Test
  • GitHub Check: Oracle
  • GitHub Check: Bindings and packages
  • GitHub Check: Enforce release boundaries / Enforce release boundaries
Additional context used
Code guidelines: 1
AGENTS.md — configured
Path-based instructions: 1
Source excerpt: Treat legal data, personal data, and repository secrets as sensitive.

CodeRabbit inference engine (AGENTS.md)

Files:

  • package.json
  • stll-toolchain.json
  • rust-toolchain.toml
Additional comments: 1
package.json: 1

59-59: LGTM!

Walkthrough

The Rust toolchain version changes from 1.99.0 to 1.99.1 across managed development setup and build workflows. The root development dependency on @stll/oxlint-config changes from 3.2.0 to 3.2.1.

Changes: Rust toolchain update

Layer / File(s) Summary
Toolchain policy and managed setup
rust-toolchain.toml, .agents/cloud-setup.sh, stll-toolchain.json, .changeset/rust-patch.md
The configured Rust version, managed setup, integrity hashes, and exception reason now refer to Rust 1.99.1. The changeset records the patch release.
CI and release workflows
.github/workflows/ci.yml, .github/workflows/mutants.yml, .github/workflows/release.yml
The workflows install or select Rust 1.99.1. Cache keys, WebAssembly target setup, and Python wheel builds also use that version.

Oxlint configuration dependency

Layer / File(s) Summary
Dependency version update
package.json
The root development dependency on @stll/oxlint-config changes from 3.2.0 to 3.2.1.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • stella/stdnum#265: Introduced the shared Rust 1.99.0 policy that this change updates.
  • stella/stdnum#283: Updated the shared lint configuration and related tooling pins, including @stll/oxlint-config.
  • stella/stdnum#278: Updated the same @stll/oxlint-config dependency line.
Merge Risk: Minimal · previous review 0953b

No actionable merge-blocking risk was identified in the toolchain or dependency updates.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adopting Rust 1.99.1 across the toolchain policy, development setup, CI, and release workflows.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 5 functions across 1 files. (7 skipped: 7 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jan-kubica
jan-kubica enabled auto-merge (squash) October 28, 2026 06:50
@jan-kubica
jan-kubica merged commit 44f1749 into main Oct 28, 2026
19 checks passed
@jan-kubica
jan-kubica deleted the chore/rust-1991-20261028 branch October 28, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant