Skip to content

NH-153412 Update builds and dev containers to ensure up-to-date OS/Python CA cert packages - #903

Open
tammy-baylis-swi wants to merge 4 commits into
mainfrom
add-ca-update-some-builds
Open

tammy-baylis-swi wants to merge 4 commits into
mainfrom
add-ca-update-some-builds

Conversation

@tammy-baylis-swi

@tammy-baylis-swi tammy-baylis-swi commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This PR updates Lambda and k8s workflows to ensure they're built with up-to-date operating system CA cert packages, and the latest Python pip, requests, and certifi.

I'm also updating the local dev containers (docker-compose run (x86_64|aarch64)) to support using organization-approved CA if required. ⚠️ This is breaking for anyone currently doing local dev work; you'll need to cp Dockerfile.manylinux.example.

See ticket for detailed explanation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new Dockerfile example lacks the required license header, causing the pull request’s license-header check to fail.

1 open issue
What changed in this PR

This PR refreshes certificate packages in Lambda and Kubernetes build environments and adds configurable organization CA support for local development containers.

Changes:

  • Add OS CA certificate refreshes and pip upgrades to build steps.
  • Build local manylinux containers from a customizable Dockerfile.
  • Document local CA configuration and ignore the customized Dockerfile.
File Description
Makefile Refresh CA certificates and upgrade pip for Lambda builds.
image/​Dockerfile-beta Add CA certificate refreshes and pip upgrades to beta image builds.
image/​Dockerfile Add CA certificate refreshes and pip upgrades to production image builds.
Dockerfile.manylinux.example Provide a template for organization CA installation and trust configuration.
docker-compose.yml Build both local architectures using the customized manylinux Dockerfile.
CONTRIBUTING.md Explain Dockerfile setup, CA configuration, and image rebuilding.
.gitignore Exclude the locally customized Dockerfile.

Review effort: Balanced

Comment thread Dockerfile.manylinux.example

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Build dependency resolution and the changed certificate setup need validation before automated approval is safe.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@tammy-baylis-swi
tammy-baylis-swi marked this pull request as ready for review October 27, 2026 19:53
@tammy-baylis-swi
tammy-baylis-swi requested review from a team as code owners October 27, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants